Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1372789
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 01/15] dmaengine: dw: fix master selection |
| Date | 2016-04-06 22:00 +0200 |
| Message-ID | <rl1Mm-uH-11@gated-at.bofh.it> (permalink) |
| References | <re3zz-7cH-7@gated-at.bofh.it> <re3Jg-7pe-31@gated-at.bofh.it> <rkgaJ-6mK-15@gated-at.bofh.it> <rkgkq-6rb-11@gated-at.bofh.it> <rl0Qj-8hK-41@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Apr 6, 2016 at 9:56 PM, Vinod Koul <vinod.koul@intel.com> wrote: > On Mon, Apr 04, 2016 at 08:10:54PM +0300, Andy Shevchenko wrote: >> On Mon, 2016-04-04 at 10:03 -0700, Vinod Koul wrote: >> > On Fri, Mar 18, 2016 at 04:24:40PM +0200, Andy Shevchenko wrote: >> > > >> > > + /* >> > > + * We need controller-specific data to set up slave >> > > transfers. >> > > + */ >> > > + BUG_ON(chan->private && !dw_dma_filter(chan, chan- >> > > >private)); >> > I don't think BUG_ON is apt here, gracefully failing and printing >> > that can >> > be better.. >> >> Hm, this is coming from the existing code. >> >> I would prefer to keep this one as is since it's targeted to stable@, >> and I may issue sequential patch to replace BUG_ON. Sounds okay? > > But since this is going stable, how about we remove here in the patch and > benefit stable tree as well? I'm fine with that. I will send you patch tomorrow.Other than that do we have any issues with the rest? -- With Best Regards, Andy Shevchenko
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v3 01/15] dmaengine: dw: fix master selection Vinod Koul <vinod.koul@intel.com> - 2016-04-04 19:10 +0200
Re: [PATCH v3 01/15] dmaengine: dw: fix master selection Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-04-04 19:20 +0200
Re: [PATCH v3 01/15] dmaengine: dw: fix master selection Vinod Koul <vinod.koul@intel.com> - 2016-04-06 21:00 +0200
Re: [PATCH v3 01/15] dmaengine: dw: fix master selection Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-04-06 22:00 +0200
Re: [PATCH v3 01/15] dmaengine: dw: fix master selection "Koul, Vinod" <vinod.koul@intel.com> - 2016-04-06 23:20 +0200
Re: [PATCH v3 01/15] dmaengine: dw: fix master selection Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-04-07 15:10 +0200
Re: [PATCH v3 01/15] dmaengine: dw: fix master selection Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-04-13 15:40 +0200
[PATCH v3.5 1/1] dmaengine: dw: fix master selection Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-04-08 15:30 +0200
csiph-web