Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1372807

Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data

Show all headers | View raw

Hello Mr. Henrik,

On Thu, Apr 7, 2016 at 1:21 AM, Henrik Rydberg <rydberg@bitmath.org> wrote:
> Hi Aniroop,
>
>>> I am not sure what the urgency is. It is more of a theoretical problem
>>> ans so far the proposed solutions were actually introducing more
>>> problems than they were solving.
>>>
>>> I am sorry, bit this particular topic is not a priority for me.
>>>
>>
>> There is no hurry at all. :-) As you know request is made a long time ago,
>> so I am only very curious to complete it.
>
> This kind of patch is not liked by any maintainer, because it does not solve any
> immediate problem, but instead may create one. If such a simple patch takes
> three of four tries to look right, it only adds to the perception that the code
> is best left alone.
>
> I think the solution at this stage is to say no to this patch.
>
> If there is ever a driver for which the input_estimate_events_per_packet()
> function returns less than the actual maximum number of events per frame, this
> issue can be revisited and resolved in a number of different ways.
>
> Sorry, and thanks for your work.
>

Well, I agree this code might not be used by any driver so far.
But if some driver developer writes such a driver, then it definitely cannot
work well because of the bug in input subsystem code. So I am afraid that it
is not a good idea to wait for someone to report this bug when we already know
that the bug does exist in input core.

Secondly, I submitted this patch not only because it breaks protocol of
SYN_REPORT event but also because without this bug fix, another bug could not
be concluded which depends on when the input event packet ended really.
Bug:
Input: evdev: fix bug of dropping valid packet after syn_dropped event
https://patchwork.kernel.org/patch/8083641/
So to fix this bug, we need to fix SYN_REPORT bug first.

It would be appreciating of you if you could give it one more spin.


> Henrik
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data Aniroop Mathur <aniroop.mathur@gmail.com> - 2016-04-02 19:10 +0200
  [PATCH] Input: Do not add SYN_REPORT in between a single packet data Aniroop Mathur <a.mathur@samsung.com> - 2016-04-04 19:30 +0200
  Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data Aniroop Mathur <aniroop.mathur@gmail.com> - 2016-04-06 17:00 +0200
    Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet  data Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-04-06 19:40 +0200
      Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data Aniroop Mathur <aniroop.mathur@gmail.com> - 2016-04-06 21:10 +0200
        Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet  data Henrik Rydberg <rydberg@bitmath.org> - 2016-04-06 22:00 +0200
          Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data Aniroop Mathur <aniroop.mathur@gmail.com> - 2016-04-06 22:50 +0200

csiph-web