Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1366519

Re: [PATCH 3/3] staging: fwserial: (coding style) Rewriting a call to a long function

Show all headers | View raw

> Does this really look better to you?
>
> Long identifiers like "wait_event_interruptible_timeout"
> (32 chars) make
> using 80 columns a bit silly.
> 
> Please remember checkpatch is a stupid script and that
> not every warning it emits is dicta.

Actually, not much and as a matter of fact, I hesitated before sending
this particular patch. That's also why I submitted it as the last one
of them all and why it fixes only a single row : so we can eventually
reject it easily.

I'm not a checkpatch.pl nazi neither and anyway, even the "Development
Process" document specify that it's not to be considered as a strict
rule if it makes the things worse.

But I found it useful anyway because this set brings back all the
warnings to only two categories (comments over spinlocks and memory
barriers) and also because this kind of minor corrections could still
be appreciated by people that have better things to do... :-)

Cheers.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] staging: fwserial: (coding style) Rewriting a call to a long function Dominique van den Broeck <domdevlin@free.fr> - 2016-03-29 19:20 +0200
  Re: [PATCH 3/3] staging: fwserial: (coding style) Rewriting a call  to a long function Joe Perches <joe@perches.com> - 2016-03-29 19:40 +0200
    Re: [PATCH 3/3] staging: fwserial: (coding style) Rewriting a call  to a long function Dominique van den Broeck <domdevlin@free.fr> - 2016-03-29 20:00 +0200
  Re: [PATCH 3/3] staging: fwserial: (coding style) Rewriting a call to  a long function Peter Hurley <peter@hurleysoftware.com> - 2016-04-01 18:40 +0200
    Re: [PATCH 3/3] staging: fwserial: (coding style) Rewriting a call  to a long function Dominique van den Broeck <domdevlin@free.fr> - 2016-04-02 01:30 +0200
      Re: [PATCH 3/3] staging: fwserial: (coding style) Rewriting a call to  a long function Peter Hurley <peter@hurleysoftware.com> - 2016-04-02 01:30 +0200

csiph-web