Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default
Date	2016-03-29 20:00 +0200
Message-ID	<ri65Q-1dr-7@gated-at.bofh.it> (permalink)
References	<rc1Lz-5Qn-3@gated-at.bofh.it> <rc1Lz-5Qn-7@gated-at.bofh.it> <rhZxo-4TD-15@gated-at.bofh.it> <ri3hE-7IL-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue 2016-03-29 16:52:09, Sebastian Reichel wrote:
> Hi,
> 
> On Tue, Mar 29, 2016 at 12:51:28PM +0200, Pavel Machek wrote:
> > For 1-3 in the series, Acked-by: Pavel Machek <pavel@ucw.cz>
> > 
> > > Like the Nokia N900, the N950 has leds to show
> > > the state of sys_clkreq and sys_off_mode pins.
> > > 
> > > A detailed description for the LEDs and
> > > OMAP's sleep states can be found in Tony's
> > > commit for the Nokia N900:
> > > 
> > > c1be2032f66df9e1238bd5bc4ca666de88a62abc
> > 
> > I must say I've seen it on N900, and yes, it is useful, but no, I
> > don't think this is right.
> >
> > This is not a LED. This is a interface that changes meaning of two
> > other LEDs. I guess it should go to debugfs somewhere.
> 
> I don't think we should diverge N900 and N950 userspace
> APIs in this regard.

That's a good argument.

But maybe we should move both to debugfs somewhere before we get too
much userspace that relies on it...

> Actually the correct way would be a custom trigger
> for the leds IMHO. I don't know if the led framework
> supports per led custom triggers, though.

Well, not even custom trigger would make this easy: AFAIK you need to
enable this on two LEDs or not at all, so you'd have one trigger _that
would need to be shared over two LEDs_.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Thread

Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default Pavel Machek <pavel@ucw.cz> - 2016-03-29 13:00 +0200
  Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default Sebastian Reichel <sre@kernel.org> - 2016-03-29 17:00 +0200
    Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default Pavel Machek <pavel@ucw.cz> - 2016-03-29 20:00 +0200
    Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default Tony Lindgren <tony@atomide.com> - 2016-03-30 21:40 +0200
      Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default Sebastian Reichel <sre@kernel.org> - 2016-03-31 02:50 +0200
      Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default Pavel Machek <pavel@ucw.cz> - 2016-04-01 14:50 +0200
        Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default Tony Lindgren <tony@atomide.com> - 2016-04-01 20:40 +0200
          Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default Pavel Machek <pavel@ucw.cz> - 2016-04-02 08:50 +0200

csiph-web