Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1366510

Re: [PATCH 3/3] staging: fwserial: (coding style) Rewriting a call to a long function

Show all headers | View raw

On Tue, 2016-03-29 at 19:14 +0200, Dominique van den Broeck wrote:
> Fixing a lone row exceeding 80 columns so the only remaining warnings
> emitted by checkpatch.pl are missing comments on spinlocks and memory
> barriers.
[]
> diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
[]
> @@ -1343,9 +1343,11 @@ static int fwtty_break_ctl(struct tty_struct *tty, int state)
>  
>  	if (state == -1) {
>  		set_bit(STOP_TX, &port->flags);
> -		ret = wait_event_interruptible_timeout(port->wait_tx,
> -					       !test_bit(IN_TX, &port->flags),
> -					       10);
> +		ret =
> +		wait_event_interruptible_timeout(port->wait_tx,
> +						 !test_bit(IN_TX, &port->flags),
> +						 10);

Does this really look better to you?

Long identifiers like "wait_event_interruptible_timeout"
(32 chars) make
using 80 columns a bit silly.

Please remember checkpatch is a stupid script and that
not every warning it emits is dicta.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] staging: fwserial: (coding style) Rewriting a call to a long function Dominique van den Broeck <domdevlin@free.fr> - 2016-03-29 19:20 +0200
  Re: [PATCH 3/3] staging: fwserial: (coding style) Rewriting a call  to a long function Joe Perches <joe@perches.com> - 2016-03-29 19:40 +0200
    Re: [PATCH 3/3] staging: fwserial: (coding style) Rewriting a call  to a long function Dominique van den Broeck <domdevlin@free.fr> - 2016-03-29 20:00 +0200
  Re: [PATCH 3/3] staging: fwserial: (coding style) Rewriting a call to  a long function Peter Hurley <peter@hurleysoftware.com> - 2016-04-01 18:40 +0200
    Re: [PATCH 3/3] staging: fwserial: (coding style) Rewriting a call  to a long function Dominique van den Broeck <domdevlin@free.fr> - 2016-04-02 01:30 +0200
      Re: [PATCH 3/3] staging: fwserial: (coding style) Rewriting a call to  a long function Peter Hurley <peter@hurleysoftware.com> - 2016-04-02 01:30 +0200

csiph-web