Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1365419

Re: [PATCH 5/6] iio: accel: kxcjk-1013: use available_scan_masks

Show all headers | View raw

On 24/03/16 09:29, Irina Tirdea wrote:
> From: Adriana Reus <adriana.reus@intel.com>
> 
> Use available_scan_masks to allow the iio core to select
> the data to send to userspace depending on which axes are
> enabled, instead of doing this in the driver's interrupt
> handler.
> 
> Signed-off-by: Adriana Reus <adriana.reus@intel.com>
> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
> Acked-by: Jonathan Cameron <jic23@kernel.org>
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied, thanks,

Jonathan
> ---
>  drivers/iio/accel/kxcjk-1013.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
> index edec1d0..3861fe9 100644
> --- a/drivers/iio/accel/kxcjk-1013.c
> +++ b/drivers/iio/accel/kxcjk-1013.c
> @@ -115,6 +115,7 @@ enum kxcjk1013_axis {
>  	AXIS_X,
>  	AXIS_Y,
>  	AXIS_Z,
> +	AXIS_MAX,
>  };
>  
>  enum kxcjk1013_mode {
> @@ -953,6 +954,8 @@ static const struct iio_info kxcjk1013_info = {
>  	.driver_module		= THIS_MODULE,
>  };
>  
> +static const unsigned long kxcjk1013_scan_masks[] = {0x7, 0};
> +
>  static irqreturn_t kxcjk1013_trigger_handler(int irq, void *p)
>  {
>  	struct iio_poll_func *pf = p;
> @@ -962,8 +965,7 @@ static irqreturn_t kxcjk1013_trigger_handler(int irq, void *p)
>  
>  	mutex_lock(&data->mutex);
>  
> -	for_each_set_bit(bit, indio_dev->active_scan_mask,
> -			 indio_dev->masklength) {
> +	for (bit = 0; bit < AXIS_MAX; bit++) {
>  		ret = kxcjk1013_get_acc_reg(data, bit);
>  		if (ret < 0) {
>  			mutex_unlock(&data->mutex);
> @@ -1204,6 +1206,7 @@ static int kxcjk1013_probe(struct i2c_client *client,
>  	indio_dev->dev.parent = &client->dev;
>  	indio_dev->channels = kxcjk1013_channels;
>  	indio_dev->num_channels = ARRAY_SIZE(kxcjk1013_channels);
> +	indio_dev->available_scan_masks = kxcjk1013_scan_masks;
>  	indio_dev->name = name;
>  	indio_dev->modes = INDIO_DIRECT_MODE;
>  	indio_dev->info = &kxcjk1013_info;
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] Driver optimizations in trigger handler Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:30 +0100
  [PATCH 2/6] iio: accel: bmc150: optimize transfers in trigger handler Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:40 +0100
    Re: [PATCH 2/6] iio: accel: bmc150: optimize transfers in trigger  handler Jonathan Cameron <jic23@kernel.org> - 2016-03-28 12:00 +0200
  [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger handler Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:40 +0100
    Re: [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger  handler Jonathan Cameron <jic23@kernel.org> - 2016-03-28 12:00 +0200
      Re: [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger  handler Peter Meerwald-Stadler <pmeerw@pmeerw.net> - 2016-03-28 12:10 +0200
        Re: [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger  handler Jonathan Cameron <jic23@kernel.org> - 2016-03-28 16:20 +0200
          RE: [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger  handler "Tirdea, Irina" <irina.tirdea@intel.com> - 2016-03-28 18:10 +0200
            Re: [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger  handler Jonathan Cameron <jic23@kernel.org> - 2016-03-28 18:20 +0200
        RE: [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger  handler "Tirdea, Irina" <irina.tirdea@intel.com> - 2016-03-28 18:10 +0200
  [PATCH 6/6] iio: accel: kxcjk-1013: optimize i2c transfers in trigger handler Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:40 +0100
    Re: [PATCH 6/6] iio: accel: kxcjk-1013: optimize i2c transfers in  trigger handler Jonathan Cameron <jic23@kernel.org> - 2016-03-28 12:00 +0200
  [PATCH 3/6] iio: gyro: bmg160: use available_scan_masks Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:40 +0100
    Re: [PATCH 3/6] iio: gyro: bmg160: use available_scan_masks Jonathan Cameron <jic23@kernel.org> - 2016-03-28 12:00 +0200
  [PATCH 1/6] iio: accel: bmc150: use available_scan_masks Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:40 +0100
    Re: [PATCH 1/6] iio: accel: bmc150: use available_scan_masks Jonathan Cameron <jic23@kernel.org> - 2016-03-28 12:00 +0200
  [PATCH 5/6] iio: accel: kxcjk-1013: use available_scan_masks Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:40 +0100
    Re: [PATCH 5/6] iio: accel: kxcjk-1013: use available_scan_masks Jonathan Cameron <jic23@kernel.org> - 2016-03-28 12:00 +0200

csiph-web