Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1365412

Re: [PATCH 3/6] iio: gyro: bmg160: use available_scan_masks

Show all headers | View raw

On 24/03/16 09:29, Irina Tirdea wrote:
> Use available_scan_masks to allow the iio core to select
> the data to send to userspace depending on which axes are
> enabled, instead of doing this in the driver's interrupt
> handler.
> 
> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Applied,

Thanks,
> ---
>  drivers/iio/gyro/bmg160_core.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/gyro/bmg160_core.c b/drivers/iio/gyro/bmg160_core.c
> index bbce3b0..8d6e5b1 100644
> --- a/drivers/iio/gyro/bmg160_core.c
> +++ b/drivers/iio/gyro/bmg160_core.c
> @@ -116,6 +116,7 @@ enum bmg160_axis {
>  	AXIS_X,
>  	AXIS_Y,
>  	AXIS_Z,
> +	AXIS_MAX,
>  };
>  
>  static const struct {
> @@ -763,6 +764,10 @@ static const struct iio_info bmg160_info = {
>  	.driver_module		= THIS_MODULE,
>  };
>  
> +static const unsigned long bmg160_accel_scan_masks[] = {
> +					BIT(AXIS_X) | BIT(AXIS_Y) | BIT(AXIS_Z),
> +					0};
> +
>  static irqreturn_t bmg160_trigger_handler(int irq, void *p)
>  {
>  	struct iio_poll_func *pf = p;
> @@ -772,8 +777,7 @@ static irqreturn_t bmg160_trigger_handler(int irq, void *p)
>  	unsigned int val;
>  
>  	mutex_lock(&data->mutex);
> -	for_each_set_bit(bit, indio_dev->active_scan_mask,
> -			 indio_dev->masklength) {
> +	for (bit = 0; bit < AXIS_MAX; bit++) {
>  		ret = regmap_bulk_read(data->regmap, BMG160_AXIS_TO_REG(bit),
>  				       &val, 2);
>  		if (ret < 0) {
> @@ -1019,6 +1023,7 @@ int bmg160_core_probe(struct device *dev, struct regmap *regmap, int irq,
>  	indio_dev->channels = bmg160_channels;
>  	indio_dev->num_channels = ARRAY_SIZE(bmg160_channels);
>  	indio_dev->name = name;
> +	indio_dev->available_scan_masks = bmg160_accel_scan_masks;
>  	indio_dev->modes = INDIO_DIRECT_MODE;
>  	indio_dev->info = &bmg160_info;
>  
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] Driver optimizations in trigger handler Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:30 +0100
  [PATCH 2/6] iio: accel: bmc150: optimize transfers in trigger handler Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:40 +0100
    Re: [PATCH 2/6] iio: accel: bmc150: optimize transfers in trigger  handler Jonathan Cameron <jic23@kernel.org> - 2016-03-28 12:00 +0200
  [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger handler Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:40 +0100
    Re: [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger  handler Jonathan Cameron <jic23@kernel.org> - 2016-03-28 12:00 +0200
      Re: [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger  handler Peter Meerwald-Stadler <pmeerw@pmeerw.net> - 2016-03-28 12:10 +0200
        Re: [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger  handler Jonathan Cameron <jic23@kernel.org> - 2016-03-28 16:20 +0200
          RE: [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger  handler "Tirdea, Irina" <irina.tirdea@intel.com> - 2016-03-28 18:10 +0200
            Re: [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger  handler Jonathan Cameron <jic23@kernel.org> - 2016-03-28 18:20 +0200
        RE: [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger  handler "Tirdea, Irina" <irina.tirdea@intel.com> - 2016-03-28 18:10 +0200
  [PATCH 6/6] iio: accel: kxcjk-1013: optimize i2c transfers in trigger handler Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:40 +0100
    Re: [PATCH 6/6] iio: accel: kxcjk-1013: optimize i2c transfers in  trigger handler Jonathan Cameron <jic23@kernel.org> - 2016-03-28 12:00 +0200
  [PATCH 3/6] iio: gyro: bmg160: use available_scan_masks Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:40 +0100
    Re: [PATCH 3/6] iio: gyro: bmg160: use available_scan_masks Jonathan Cameron <jic23@kernel.org> - 2016-03-28 12:00 +0200
  [PATCH 1/6] iio: accel: bmc150: use available_scan_masks Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:40 +0100
    Re: [PATCH 1/6] iio: accel: bmc150: use available_scan_masks Jonathan Cameron <jic23@kernel.org> - 2016-03-28 12:00 +0200
  [PATCH 5/6] iio: accel: kxcjk-1013: use available_scan_masks Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:40 +0100
    Re: [PATCH 5/6] iio: accel: kxcjk-1013: use available_scan_masks Jonathan Cameron <jic23@kernel.org> - 2016-03-28 12:00 +0200

csiph-web