Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1365413

Re: [PATCH 6/6] iio: accel: kxcjk-1013: optimize i2c transfers in trigger handler

Show all headers | View raw

On 24/03/16 09:29, Irina Tirdea wrote:
> From: Adriana Reus <adriana.reus@intel.com>
> 
> Some i2c busses (e.g.: Synopsys DesignWare I2C adapter) need to
> enable/disable the bus at each i2c transfer and must wait for
> the enable/disable to happen before sending the data.
> 
> When reading data in the trigger handler, the kxcjk-1013 accel driver
> does one i2c transfer for each axis. This has an impact on the
> frequency of the accelerometer at high sample rates due to additional
> delays introduced by the i2c bus at each transfer.
> 
> Reading all axis values in one i2c transfer reduces the delays
> introduced by the i2c bus. Uses i2c_smbus_read_i2c_block_data_or_emulated
> that will fallback to reading each axis as a separate word in case i2c
> block read is not supported.
> 
> Signed-off-by: Adriana Reus <adriana.reus@intel.com>
> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
> Acked-by: Jonathan Cameron <jic23@kernel.org>
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied - with all the others to the togreg branch of iio.git - initially pushed out
as testing for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/accel/kxcjk-1013.c | 19 ++++++++-----------
>  1 file changed, 8 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
> index 3861fe9..4881856 100644
> --- a/drivers/iio/accel/kxcjk-1013.c
> +++ b/drivers/iio/accel/kxcjk-1013.c
> @@ -923,7 +923,7 @@ static const struct iio_event_spec kxcjk1013_event = {
>  		.realbits = 12,						\
>  		.storagebits = 16,					\
>  		.shift = 4,						\
> -		.endianness = IIO_CPU,					\
> +		.endianness = IIO_LE,					\
>  	},								\
>  	.event_spec = &kxcjk1013_event,				\
>  	.num_event_specs = 1						\
> @@ -961,19 +961,16 @@ static irqreturn_t kxcjk1013_trigger_handler(int irq, void *p)
>  	struct iio_poll_func *pf = p;
>  	struct iio_dev *indio_dev = pf->indio_dev;
>  	struct kxcjk1013_data *data = iio_priv(indio_dev);
> -	int bit, ret, i = 0;
> +	int ret;
>  
>  	mutex_lock(&data->mutex);
> -
> -	for (bit = 0; bit < AXIS_MAX; bit++) {
> -		ret = kxcjk1013_get_acc_reg(data, bit);
> -		if (ret < 0) {
> -			mutex_unlock(&data->mutex);
> -			goto err;
> -		}
> -		data->buffer[i++] = ret;
> -	}
> +	ret = i2c_smbus_read_i2c_block_data_or_emulated(data->client,
> +							KXCJK1013_REG_XOUT_L,
> +							AXIS_MAX * 2,
> +							(u8 *)data->buffer);
>  	mutex_unlock(&data->mutex);
> +	if (ret < 0)
> +		goto err;
>  
>  	iio_push_to_buffers_with_timestamp(indio_dev, data->buffer,
>  					   data->timestamp);
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] Driver optimizations in trigger handler Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:30 +0100
  [PATCH 2/6] iio: accel: bmc150: optimize transfers in trigger handler Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:40 +0100
    Re: [PATCH 2/6] iio: accel: bmc150: optimize transfers in trigger  handler Jonathan Cameron <jic23@kernel.org> - 2016-03-28 12:00 +0200
  [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger handler Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:40 +0100
    Re: [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger  handler Jonathan Cameron <jic23@kernel.org> - 2016-03-28 12:00 +0200
      Re: [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger  handler Peter Meerwald-Stadler <pmeerw@pmeerw.net> - 2016-03-28 12:10 +0200
        Re: [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger  handler Jonathan Cameron <jic23@kernel.org> - 2016-03-28 16:20 +0200
          RE: [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger  handler "Tirdea, Irina" <irina.tirdea@intel.com> - 2016-03-28 18:10 +0200
            Re: [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger  handler Jonathan Cameron <jic23@kernel.org> - 2016-03-28 18:20 +0200
        RE: [PATCH 4/6] iio: accel: bmg160: optimize transfers in trigger  handler "Tirdea, Irina" <irina.tirdea@intel.com> - 2016-03-28 18:10 +0200
  [PATCH 6/6] iio: accel: kxcjk-1013: optimize i2c transfers in trigger handler Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:40 +0100
    Re: [PATCH 6/6] iio: accel: kxcjk-1013: optimize i2c transfers in  trigger handler Jonathan Cameron <jic23@kernel.org> - 2016-03-28 12:00 +0200
  [PATCH 3/6] iio: gyro: bmg160: use available_scan_masks Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:40 +0100
    Re: [PATCH 3/6] iio: gyro: bmg160: use available_scan_masks Jonathan Cameron <jic23@kernel.org> - 2016-03-28 12:00 +0200
  [PATCH 1/6] iio: accel: bmc150: use available_scan_masks Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:40 +0100
    Re: [PATCH 1/6] iio: accel: bmc150: use available_scan_masks Jonathan Cameron <jic23@kernel.org> - 2016-03-28 12:00 +0200
  [PATCH 5/6] iio: accel: kxcjk-1013: use available_scan_masks Irina Tirdea <irina.tirdea@intel.com> - 2016-03-24 10:40 +0100
    Re: [PATCH 5/6] iio: accel: kxcjk-1013: use available_scan_masks Jonathan Cameron <jic23@kernel.org> - 2016-03-28 12:00 +0200

csiph-web