Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1364775

Re: [PATCH] regulator: twl: Enable regulators over the powerbus as well

Show all headers | View raw

On 25.03.2016 18:19, Mark Brown wrote:
> On Fri, Mar 25, 2016 at 06:09:27PM +0200, Ivaylo Dimitrov wrote:
>
>> Ok, so you say that regulator framework should call twl4030reg_set_mode(),
>> but it doesn't. If that is the case, then the bug is in the regulator
>> framework, a similar one to what you've fixed in "regulator: core: Always
>> flag voltage constraints as appliable".
>
> What makes you claim that this is a bug in the framework?  Does anything
> in the machine configuration say that changing the modes is allowed?
>

My understanding is that regulator core have to make sure an enabled 
regulator to be in REGULATOR_STATUS_NORMAL. Now it enables the 
regulator, but does not make it in REGULATOR_STATUS_NORMAL. There are 3 
places set_mode() is called in regulator/core.c - in drms_uA_update(), 
in regulator_set_mode() and in set_machine_constraints(). 
set_machine_constraints() calls set_mode() only if there is initial mode 
for that regulator. I can't find a call to regulator_set_mode() anywhere 
in the tree.

 From the documentation:

"regulator-initial-mode: initial operating mode...."

Does the above imply that every regulator present in the system must 
have "initial-mode" defined even if it is "always-on" regulator?

Also, who puts a regulator out of REGULATOR_STATUS_NORMAL if there are 
no more consumers?

It might be that I am not getting the logic behind.

Ivo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] regulator: twl: Enable regulators over the powerbus as well Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-03-23 20:30 +0100
  Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 12:20 +0100
    Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Sebastian Reichel <sre@kernel.org> - 2016-03-25 16:10 +0100
      Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 17:00 +0100
        Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-03-25 17:20 +0100
          Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 17:30 +0100
            Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-03-25 18:00 +0100
              Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 18:10 +0100
                Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-03-25 18:30 +0100
                Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 19:30 +0100
                Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Sebastian Reichel <sre@kernel.org> - 2016-03-25 21:20 +0100
                Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 23:30 +0100
                Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-03-26 07:20 +0100
        Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Sebastian Reichel <sre@kernel.org> - 2016-03-25 17:50 +0100
          Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 18:30 +0100

csiph-web