Re: [PATCH] regulator: twl: Enable regulators over the powerbus as well

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] regulator: twl: Enable regulators over the powerbus as well
Date	2016-03-25 18:30 +0100
Message-ID	<rgDID-55j-21@gated-at.bofh.it> (permalink)
References	<rfWDD-83n-3@gated-at.bofh.it> <rgxWz-Rf-67@gated-at.bofh.it> <rgBx8-3pJ-1@gated-at.bofh.it> <rgCjx-3QV-27@gated-at.bofh.it> <rgD5U-4yf-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Mar 25, 2016 at 05:47:50PM +0100, Sebastian Reichel wrote:

> I just tried to describe what's going on, so that you can see the
> whole picture. I don't agree with the patch and think that the mode
> should be switched to normal at probe time. I assumed, that you
> would suggest the correct solution if I describe the problem.

Well, I'm not 100% sure what's going on.  If there is a constraint in
the system that requires setting the mode then something needs to
set that but it sounds like it might be more the case that the mode
support in this driver is just broken at the minute if it's not
orthogonal to the enable support.  Perhaps the mode API is being used
for suspend states or something?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] regulator: twl: Enable regulators over the powerbus as well Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-03-23 20:30 +0100
  Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 12:20 +0100
    Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Sebastian Reichel <sre@kernel.org> - 2016-03-25 16:10 +0100
      Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 17:00 +0100
        Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-03-25 17:20 +0100
          Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 17:30 +0100
            Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-03-25 18:00 +0100
              Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 18:10 +0100
                Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-03-25 18:30 +0100
                Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 19:30 +0100
                Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Sebastian Reichel <sre@kernel.org> - 2016-03-25 21:20 +0100
                Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 23:30 +0100
                Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-03-26 07:20 +0100
        Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Sebastian Reichel <sre@kernel.org> - 2016-03-25 17:50 +0100
          Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 18:30 +0100

csiph-web