Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1364791

Re: [PATCH] regulator: twl: Enable regulators over the powerbus as well

Show all headers | View raw

On 25.03.2016 19:05, Mark Brown wrote:
> On Fri, Mar 25, 2016 at 06:50:18PM +0200, Ivaylo Dimitrov wrote:
>> On 25.03.2016 18:19, Mark Brown wrote:
>
>>> What makes you claim that this is a bug in the framework?  Does anything
>>> in the machine configuration say that changing the modes is allowed?
>
>> My understanding is that regulator core have to make sure an enabled
>> regulator to be in REGULATOR_STATUS_NORMAL. Now it enables the regulator,
>
> No, absolutely not.  Modes are completely orthogonal to enabling and
> disabling the regulator - modes reflect an efficiency/accuracy tradeoff
> in the regulation, they are nothing to do with the regulator being
> enabled.  Setting a mode should not affect the regulator enable state
> and enabling the regulator should not affect the mode.
>
>> It might be that I am not getting the logic behind.
>
> Yes, that seems to be the case.
>

Fair enough.

Now, what am I supposed to do to the fix the problem. Will try to 
explain it in more details:

On Nokia N900 regulators are left in the mode last set by the bootloader 
or by the stock kernel, depends on whether it is power-on or reboot from 
stock kernel to mainline. That leads to problem with devices connected 
to vmmc2 regulator - when the device is rebooted from stock kernel vmmc2 
is left in "sleep" mode (REGULATOR_STATUS_STANDBY in terms of regulator 
framework) and as noone in mainline kernel switches vmmc2 regulator to 
normal (REGULATOR_STATUS_NORMAL) mode, devices supplied by it does not 
get enough power to operate normally.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] regulator: twl: Enable regulators over the powerbus as well Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-03-23 20:30 +0100
  Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 12:20 +0100
    Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Sebastian Reichel <sre@kernel.org> - 2016-03-25 16:10 +0100
      Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 17:00 +0100
        Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-03-25 17:20 +0100
          Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 17:30 +0100
            Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-03-25 18:00 +0100
              Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 18:10 +0100
                Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-03-25 18:30 +0100
                Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 19:30 +0100
                Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Sebastian Reichel <sre@kernel.org> - 2016-03-25 21:20 +0100
                Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 23:30 +0100
                Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-03-26 07:20 +0100
        Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Sebastian Reichel <sre@kernel.org> - 2016-03-25 17:50 +0100
          Re: [PATCH] regulator: twl: Enable regulators over the powerbus as  well Mark Brown <broonie@kernel.org> - 2016-03-25 18:30 +0100

csiph-web