Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1363353
| Path | csiph.com!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Thomas Gleixner <tglx@linutronix.de> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] Disable UV BAU by default |
| Date | Wed, 23 Mar 2016 12:30:02 +0100 |
| Message-ID | <rfP98-2DP-13@gated-at.bofh.it> (permalink) |
| References | <rfbEK-mO-15@gated-at.bofh.it> <rfbEM-mO-29@gated-at.bofh.it> |
| User-Agent | Alpine 2.11 (DEB 23 2013-08-11) |
| MIME-Version | 1.0 |
| Content-Type | TEXT/PLAIN; charset=US-ASCII |
| X-Linutronix-Spam-Score | -1.0 |
| X-Linutronix-Spam-Level | - |
| X-Linutronix-Spam-Status | No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 48 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, Hedi Berriche <hedi@sgi.com>, x86@kernel.org |
| X-Original-Date | Wed, 23 Mar 2016 12:27:44 +0100 (CET) |
| X-Original-Message-ID | <alpine.DEB.2.11.1603231223440.3978@nanos> |
| X-Original-References | <1458579852-37580-1-git-send-email-athorlton@sgi.com> <1458579852-37580-2-git-send-email-athorlton@sgi.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1363353 |
Show key headers only | View raw
On Mon, 21 Mar 2016, Alex Thorlton wrote:
First of all, please use proper patch prefixes.
x86/platform/uv: ....
And please fold the documentation change into the patch which changes the
parameter.
> static int timeout_us;
> -static int nobau;
> +static int nobau = 1;
> static int nobau_perm;
> static cycles_t congested_cycles;
>
> @@ -106,13 +106,22 @@ static char *stat_description[] = {
> "enable: number times use of the BAU was re-enabled"
> };
>
> -static int __init
> -setup_nobau(char *arg)
> +static int __init setup_bau(char *arg)
> {
> - nobau = 1;
> + if (!arg)
> + return -EINVAL;
> +
> + if (!strncmp(arg, "on", 2)) {
> + nobau = 0;
> + pr_info("UV BAU Enabled\n");
> + } else if (!strncmp(arg, "off", 3)) {
> + nobau = 1;
> + pr_info("UV BAU Disabled\n");
> + }
> +
> return 0;
> }
> -early_param("nobau", setup_nobau);
> +early_param("bau", setup_bau);
What's the value of having that extra argument?
The default is off, so we can do with a simple "bau" or "enable_bau" and be
done with it.
Thanks,
tglx
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] Re-work UV BAU enable/disable logic, add documentation Alex Thorlton <athorlton@sgi.com> - 2016-03-21 18:20 +0100
[PATCH 1/2] Disable UV BAU by default Alex Thorlton <athorlton@sgi.com> - 2016-03-21 18:20 +0100
Re: [PATCH 1/2] Disable UV BAU by default Thomas Gleixner <tglx@linutronix.de> - 2016-03-23 12:30 +0100
Re: [PATCH 1/2] Disable UV BAU by default Alex Thorlton <athorlton@sgi.com> - 2016-03-23 17:20 +0100
Re: [PATCH 1/2] Disable UV BAU by default Alex Thorlton <athorlton@sgi.com> - 2016-03-23 18:30 +0100
Re: [PATCH 1/2] Disable UV BAU by default Thomas Gleixner <tglx@linutronix.de> - 2016-03-23 18:30 +0100
[PATCH 2/2] Add documentation for the bau parameter Alex Thorlton <athorlton@sgi.com> - 2016-03-21 18:20 +0100
csiph-web