Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1363519

Re: [PATCH 1/2] Disable UV BAU by default

Show all headers | View raw

On Wed, Mar 23, 2016 at 12:27:44PM +0100, Thomas Gleixner wrote:
> On Mon, 21 Mar 2016, Alex Thorlton wrote:
> 
> First of all, please use proper patch prefixes.
> 
> x86/platform/uv: ....

Ah - sorry about that!

> And please fold the documentation change into the patch which changes the
> parameter.

Got it.  No problem!

> > +	if (!strncmp(arg, "on", 2)) {
> > +		nobau = 0;
> > +		pr_info("UV BAU Enabled\n");
> > +	} else if (!strncmp(arg, "off", 3)) {
> > +		nobau = 1;
> > +		pr_info("UV BAU Disabled\n");
> > +	}
> 
> What's the value of having that extra argument?
> 
> The default is off, so we can do with a simple "bau" or "enable_bau" and be
> done with it.

This was actually what I initially wrote, but we decided to go with the
on/off switch instead, because, in the UV4 time-frame, we're hoping to
get a few things changed so that we can default to having the bau *on*
for the new UV4 systems.

I left that detail out of the original commit message, as I didn't
figure our future (still tentative) plans were all that important to the
community.  I can add that information to my commit message, if you
would prefer to see it there.

I'll get the other stuff fixed up.  Please let me know if you'd like for
me to give a bit more detail in the commit message about the motivation
for the on/off switch vs. an enable flag.

Thanks for the input!

- Alex

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] Re-work UV BAU enable/disable logic, add documentation Alex Thorlton <athorlton@sgi.com> - 2016-03-21 18:20 +0100
  [PATCH 1/2] Disable UV BAU by default Alex Thorlton <athorlton@sgi.com> - 2016-03-21 18:20 +0100
    Re: [PATCH 1/2] Disable UV BAU by default Thomas Gleixner <tglx@linutronix.de> - 2016-03-23 12:30 +0100
      Re: [PATCH 1/2] Disable UV BAU by default Alex Thorlton <athorlton@sgi.com> - 2016-03-23 17:20 +0100
        Re: [PATCH 1/2] Disable UV BAU by default Alex Thorlton <athorlton@sgi.com> - 2016-03-23 18:30 +0100
        Re: [PATCH 1/2] Disable UV BAU by default Thomas Gleixner <tglx@linutronix.de> - 2016-03-23 18:30 +0100
  [PATCH 2/2] Add documentation for the bau parameter Alex Thorlton <athorlton@sgi.com> - 2016-03-21 18:20 +0100

csiph-web