Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1363353

Re: [PATCH 1/2] Disable UV BAU by default

Show all headers | View raw

On Mon, 21 Mar 2016, Alex Thorlton wrote:

First of all, please use proper patch prefixes.

x86/platform/uv: ....

And please fold the documentation change into the patch which changes the
parameter.

>  static int timeout_us;
> -static int nobau;
> +static int nobau = 1;
>  static int nobau_perm;
>  static cycles_t congested_cycles;
>  
> @@ -106,13 +106,22 @@ static char *stat_description[] = {
>  	"enable:   number times use of the BAU was re-enabled"
>  };
>  
> -static int __init
> -setup_nobau(char *arg)
> +static int __init setup_bau(char *arg)
>  {
> -	nobau = 1;
> +	if (!arg)
> +		return -EINVAL;
> +
> +	if (!strncmp(arg, "on", 2)) {
> +		nobau = 0;
> +		pr_info("UV BAU Enabled\n");
> +	} else if (!strncmp(arg, "off", 3)) {
> +		nobau = 1;
> +		pr_info("UV BAU Disabled\n");
> +	}
> +
>  	return 0;
>  }
> -early_param("nobau", setup_nobau);
> +early_param("bau", setup_bau);

What's the value of having that extra argument?

The default is off, so we can do with a simple "bau" or "enable_bau" and be
done with it.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] Re-work UV BAU enable/disable logic, add documentation Alex Thorlton <athorlton@sgi.com> - 2016-03-21 18:20 +0100
  [PATCH 1/2] Disable UV BAU by default Alex Thorlton <athorlton@sgi.com> - 2016-03-21 18:20 +0100
    Re: [PATCH 1/2] Disable UV BAU by default Thomas Gleixner <tglx@linutronix.de> - 2016-03-23 12:30 +0100
      Re: [PATCH 1/2] Disable UV BAU by default Alex Thorlton <athorlton@sgi.com> - 2016-03-23 17:20 +0100
        Re: [PATCH 1/2] Disable UV BAU by default Alex Thorlton <athorlton@sgi.com> - 2016-03-23 18:30 +0100
        Re: [PATCH 1/2] Disable UV BAU by default Thomas Gleixner <tglx@linutronix.de> - 2016-03-23 18:30 +0100
  [PATCH 2/2] Add documentation for the bau parameter Alex Thorlton <athorlton@sgi.com> - 2016-03-21 18:20 +0100

csiph-web