Re: [PATCH] cpufreq: Do not schedule policy update work in cpufreq_resume()

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cpufreq: Do not schedule policy update work in cpufreq_resume()
Date	2016-03-17 07:50 +0100
Message-ID	<rdzUR-3Ge-1@gated-at.bofh.it> (permalink)
References	(1 earlier) <rcQuJ-6Fh-1@gated-at.bofh.it> <rcW78-1Xi-5@gated-at.bofh.it> <rd7YC-1nQ-9@gated-at.bofh.it> <rdbIT-3R6-11@gated-at.bofh.it> <rdiKm-rP-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 16-03-16, 13:29, Rafael J. Wysocki wrote:
> On Wed, Mar 16, 2016 at 5:52 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > Not just that. We wouldn't call syscore-ops for the boot-cpu. It never went
> > away.
> 
> Yes, we would.
> 
> We actually call syscore ops *only* on that CPU.

Ahh, I thought you are talking about subsys-callbacks which we use while
registering cpufreq drivers.

> >> Still, though, the way it is done now is really awful and has to go.
> >>
> >> I guess something along the lines of cpufreq_update_policy() might be
> >> done in cpufreq_resume() before governors are started, but it might
> >> even be better to set policy->cur from scratch when starting the
> >> governors.  Just do driver->get() and set policy->cur to what that
> >> returns (or just use the average of min and max if ->get is not
> >> available).  And that unconditionally, regardless of the reason why
> >> the governors are started.
> >
> > I think doing it from a somewhat centric location would make more sense then
> > pushing this for the governors.
> 
> I'm not talking about doing that in governors, but in
> cpufreq_governor() when the event is _START.

Yeah, that shall be fine.

-- 
viresh

Thread

[PATCH] cpufreq: Do not schedule policy update work in cpufreq_resume() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-03-12 03:10 +0100
  Re: [PATCH] cpufreq: Do not schedule policy update work in  cpufreq_resume() Viresh Kumar <viresh.kumar@linaro.org> - 2016-03-15 07:20 +0100
    Re: [PATCH] cpufreq: Do not schedule policy update work in cpufreq_resume() "Rafael J. Wysocki" <rafael@kernel.org> - 2016-03-15 13:20 +0100
      Re: [PATCH] cpufreq: Do not schedule policy update work in cpufreq_resume() "Rafael J. Wysocki" <rafael@kernel.org> - 2016-03-16 02:00 +0100
        Re: [PATCH] cpufreq: Do not schedule policy update work in  cpufreq_resume() Viresh Kumar <viresh.kumar@linaro.org> - 2016-03-16 06:00 +0100
          Re: [PATCH] cpufreq: Do not schedule policy update work in cpufreq_resume() "Rafael J. Wysocki" <rafael@kernel.org> - 2016-03-16 13:30 +0100
            Re: [PATCH] cpufreq: Do not schedule policy update work in  cpufreq_resume() Viresh Kumar <viresh.kumar@linaro.org> - 2016-03-17 07:50 +0100
      Re: [PATCH] cpufreq: Do not schedule policy update work in  cpufreq_resume() Viresh Kumar <viresh.kumar@linaro.org> - 2016-03-16 05:50 +0100
        Re: [PATCH] cpufreq: Do not schedule policy update work in cpufreq_resume() "Rafael J. Wysocki" <rafael@kernel.org> - 2016-03-16 14:20 +0100
          Re: [PATCH] cpufreq: Do not schedule policy update work in  cpufreq_resume() Viresh Kumar <viresh.kumar@linaro.org> - 2016-03-17 07:40 +0100

csiph-web