Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1359599

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

From Leon Romanovsky <leon@leon.nu>
Newsgroups linux.kernel
Subject Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support
Date 2016-03-17 07:50 +0100
Message-ID <rdzUS-3Ge-5@gated-at.bofh.it> (permalink)
References <rbsuu-4D2-7@gated-at.bofh.it> <rbsuu-4D2-29@gated-at.bofh.it> <rbsNQ-4Mh-9@gated-at.bofh.it> <rdh1U-7IW-13@gated-at.bofh.it> <rdh1T-7IW-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 16, 2016 at 11:36:38AM +0100, Jiri Pirko wrote:
> >so, I continue to have it.
> 
> I will continue to bash on your odd codingstyle. Please fix it!

Jiri,

Checkpatch errors is an easiest issue with this patch.

It is full of functions without use, unconnected macros and
if you replace "hsi" to name of other well known driver, you will get
same code :).

They need to redesign the whole driver before resubmission.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] infiniband: IB/hns: Hisilicon RoCE support Lijun Ou <oulijun@huawei.com> - 2016-03-11 11:30 +0100
  Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support Jiri Pirko <jiri@resnulli.us> - 2016-03-11 11:50 +0100
    Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support Jiri Pirko <jiri@resnulli.us> - 2016-03-16 11:40 +0100
      Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support Leon Romanovsky <leon@leon.nu> - 2016-03-17 07:50 +0100
        Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support oulijun <oulijun@huawei.com> - 2016-03-19 12:20 +0100
    Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support oulijun <oulijun@huawei.com> - 2016-03-16 11:40 +0100
  Re: [PATCH 0/3] infiniband: IB/hns: Hisilicon RoCE support Leon Romanovsky <leon@leon.nu> - 2016-03-12 12:00 +0100
    Re: [PATCH 0/3] infiniband: IB/hns: Hisilicon RoCE support oulijun <oulijun@huawei.com> - 2016-03-19 12:20 +0100
  Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support Leon Romanovsky <leon@leon.nu> - 2016-03-12 12:00 +0100
    Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support oulijun <oulijun@huawei.com> - 2016-03-16 11:40 +0100

csiph-web