Re: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller
Date	2016-03-16 13:10 +0100
Message-ID	<rdir1-kr-31@gated-at.bofh.it> (permalink)
References	<r8VMl-5IQ-1@gated-at.bofh.it> <rbxNw-hy-7@gated-at.bofh.it> <rbBHs-32u-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Mar 11, 2016 at 9:03 PM, Matthias Brugger <mbrugger@suse.com> wrote:
> On Fri, 2016-03-11 at 23:01 +0700, Linus Walleij wrote:
>> On Fri, Mar 4, 2016 at 5:59 PM, Matthias Brugger <mbrugger@suse.com>
>> wrote:
>>
>> > The standby GPIO controller can be used as a interrupt controller.
>> > Select GPIOLIB_IRQCHIP when compiling this driver. Otherwise we get
>> > a compilation error:
>> >
>> > drivers/gpio/gpio-xgene-sb.c: In function 'xgene_gpio_sb_probe':
>> > drivers/gpio/gpio-xgene-sb.c:312:10: error: 'struct gpio_chip' has
>> > no member named 'irqdomain'
>> >   priv->gc.irqdomain = priv->irq_domain;
>> >           ^
>> > scripts/Makefile.build:295: recipe for target 'drivers/gpio/gpio
>> > -xgene-sb.o' failed
>> > make[2]: *** [drivers/gpio/gpio-xgene-sb.o] Error 1
>> >
>> > Fixes: 1013fc41 "gpio: xgene: Enable X-Gene standby GPIO as
>> > interrupt controller"
>> > Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>>
>> Quan's patch exporting the symbols has been merged by tglx
>> so dropping this.
>>
>
> Thanks for the info.
>
> Actually this is v1 [1] of the patch, which just addresses the
> GPIOLIB_IRQCHIP problem?
> With Quan's patch this should still be present.

Ah sorry I screwed up here and confused the patches.

Patch applied.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller Matthias Brugger <mbrugger@suse.com> - 2016-03-04 12:10 +0100
  Re: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller Quan Nguyen <qnguyen@apm.com> - 2016-03-08 05:40 +0100
  Re: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller Linus Walleij <linus.walleij@linaro.org> - 2016-03-11 17:10 +0100
    Re: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller Matthias Brugger <mbrugger@suse.com> - 2016-03-11 21:20 +0100
      Re: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller Linus Walleij <linus.walleij@linaro.org> - 2016-03-16 13:10 +0100

csiph-web