Re: [PATCH] gpio: pca953x: Fix pca953x_gpio_set_multiple() on 64-bit

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gpio: pca953x: Fix pca953x_gpio_set_multiple() on 64-bit
Date	2016-03-16 13:10 +0100
Message-ID	<rdir1-kr-29@gated-at.bofh.it> (permalink)
References	<rbygy-y0-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Mar 11, 2016 at 5:31 PM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:

> pca953x_gpio_set_multiple() divides by 4 to convert from longs to bytes,
> which assumes a 32-bit platform, and is not correct on 64-bit platforms.
> Use "sizeof(...)" instead to fix this.
>
> Fixes: b4818afeacbd8182 ("gpio: pca953x: Add set_multiple to allow multiple bits to be set in one write.")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Patch applied for fixes. Tagged for stable.
Ack from Phil.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] gpio: pca953x: Fix pca953x_gpio_set_multiple() on 64-bit Geert Uytterhoeven <geert+renesas@glider.be> - 2016-03-11 17:40 +0100
  Re: [PATCH] gpio: pca953x: Fix pca953x_gpio_set_multiple() on 64-bit Phil Reid <preid@electromag.com.au> - 2016-03-12 16:30 +0100
  Re: [PATCH] gpio: pca953x: Fix pca953x_gpio_set_multiple() on 64-bit Linus Walleij <linus.walleij@linaro.org> - 2016-03-16 13:10 +0100

csiph-web