Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1350154 > unrolled thread

[PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller

Started byMatthias Brugger <mbrugger@suse.com>
First post2016-03-04 12:10 +0100
Last post2016-03-16 13:10 +0100
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller Matthias Brugger <mbrugger@suse.com> - 2016-03-04 12:10 +0100
    Re: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller Quan Nguyen <qnguyen@apm.com> - 2016-03-08 05:40 +0100
    Re: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller Linus Walleij <linus.walleij@linaro.org> - 2016-03-11 17:10 +0100
      Re: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller Matthias Brugger <mbrugger@suse.com> - 2016-03-11 21:20 +0100
        Re: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller Linus Walleij <linus.walleij@linaro.org> - 2016-03-16 13:10 +0100

#1350154 — [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller

FromMatthias Brugger <mbrugger@suse.com>
Date2016-03-04 12:10 +0100
Subject[PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller
Message-ID<r8VMl-5IQ-1@gated-at.bofh.it>
The standby GPIO controller can be used as a interrupt controller.
Select GPIOLIB_IRQCHIP when compiling this driver. Otherwise we get
a compilation error:

drivers/gpio/gpio-xgene-sb.c: In function 'xgene_gpio_sb_probe':
drivers/gpio/gpio-xgene-sb.c:312:10: error: 'struct gpio_chip' has no member named 'irqdomain'
  priv->gc.irqdomain = priv->irq_domain;
          ^
scripts/Makefile.build:295: recipe for target 'drivers/gpio/gpio-xgene-sb.o' failed
make[2]: *** [drivers/gpio/gpio-xgene-sb.o] Error 1

Fixes: 1013fc41 "gpio: xgene: Enable X-Gene standby GPIO as interrupt controller"
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
 drivers/gpio/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 619767b..d9d6cfe 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -452,6 +452,7 @@ config GPIO_XGENE_SB
 	tristate "APM X-Gene GPIO standby controller support"
 	depends on ARCH_XGENE && OF_GPIO
 	select GPIO_GENERIC
+	select GPIOLIB_IRQCHIP
 	help
 	  This driver supports the GPIO block within the APM X-Gene
 	  Standby Domain. Say yes here to enable the GPIO functionality.
-- 
2.6.2

[toc] | [next] | [standalone]

#1352620

FromQuan Nguyen <qnguyen@apm.com>
Date2016-03-08 05:40 +0100
Message-ID<rahB7-4l1-3@gated-at.bofh.it>
In reply to#1350154
On Fri, Mar 4, 2016 at 5:59 PM, Matthias Brugger <mbrugger@suse.com> wrote:
> The standby GPIO controller can be used as a interrupt controller.
> Select GPIOLIB_IRQCHIP when compiling this driver. Otherwise we get
> a compilation error:
>
> drivers/gpio/gpio-xgene-sb.c: In function 'xgene_gpio_sb_probe':
> drivers/gpio/gpio-xgene-sb.c:312:10: error: 'struct gpio_chip' has no member named 'irqdomain'
>   priv->gc.irqdomain = priv->irq_domain;
>           ^
> scripts/Makefile.build:295: recipe for target 'drivers/gpio/gpio-xgene-sb.o' failed
> make[2]: *** [drivers/gpio/gpio-xgene-sb.o] Error 1
>
> Fixes: 1013fc41 "gpio: xgene: Enable X-Gene standby GPIO as interrupt controller"
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> ---
>  drivers/gpio/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>

Acked-by: Quan Nguyen <qnguyen@apm.com>

[toc] | [prev] | [next] | [standalone]

#1356021

FromLinus Walleij <linus.walleij@linaro.org>
Date2016-03-11 17:10 +0100
Message-ID<rbxNw-hy-7@gated-at.bofh.it>
In reply to#1350154
On Fri, Mar 4, 2016 at 5:59 PM, Matthias Brugger <mbrugger@suse.com> wrote:

> The standby GPIO controller can be used as a interrupt controller.
> Select GPIOLIB_IRQCHIP when compiling this driver. Otherwise we get
> a compilation error:
>
> drivers/gpio/gpio-xgene-sb.c: In function 'xgene_gpio_sb_probe':
> drivers/gpio/gpio-xgene-sb.c:312:10: error: 'struct gpio_chip' has no member named 'irqdomain'
>   priv->gc.irqdomain = priv->irq_domain;
>           ^
> scripts/Makefile.build:295: recipe for target 'drivers/gpio/gpio-xgene-sb.o' failed
> make[2]: *** [drivers/gpio/gpio-xgene-sb.o] Error 1
>
> Fixes: 1013fc41 "gpio: xgene: Enable X-Gene standby GPIO as interrupt controller"
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>

Quan's patch exporting the symbols has been merged by tglx
so dropping this.

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]

#1356171

FromMatthias Brugger <mbrugger@suse.com>
Date2016-03-11 21:20 +0100
Message-ID<rbBHs-32u-11@gated-at.bofh.it>
In reply to#1356021
On Fri, 2016-03-11 at 23:01 +0700, Linus Walleij wrote:
> On Fri, Mar 4, 2016 at 5:59 PM, Matthias Brugger <mbrugger@suse.com>
> wrote:
> 
> > The standby GPIO controller can be used as a interrupt controller.
> > Select GPIOLIB_IRQCHIP when compiling this driver. Otherwise we get
> > a compilation error:
> > 
> > drivers/gpio/gpio-xgene-sb.c: In function 'xgene_gpio_sb_probe':
> > drivers/gpio/gpio-xgene-sb.c:312:10: error: 'struct gpio_chip' has
> > no member named 'irqdomain'
> >   priv->gc.irqdomain = priv->irq_domain;
> >           ^
> > scripts/Makefile.build:295: recipe for target 'drivers/gpio/gpio
> > -xgene-sb.o' failed
> > make[2]: *** [drivers/gpio/gpio-xgene-sb.o] Error 1
> > 
> > Fixes: 1013fc41 "gpio: xgene: Enable X-Gene standby GPIO as
> > interrupt controller"
> > Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> 
> Quan's patch exporting the symbols has been merged by tglx
> so dropping this.
> 

Thanks for the info.

Actually this is v1 [1] of the patch, which just addresses the
GPIOLIB_IRQCHIP problem?
With Quan's patch this should still be present.

[1] https://patchwork.kernel.org/patch/8502401/

[toc] | [prev] | [next] | [standalone]

#1358937

FromLinus Walleij <linus.walleij@linaro.org>
Date2016-03-16 13:10 +0100
Message-ID<rdir1-kr-31@gated-at.bofh.it>
In reply to#1356171
On Fri, Mar 11, 2016 at 9:03 PM, Matthias Brugger <mbrugger@suse.com> wrote:
> On Fri, 2016-03-11 at 23:01 +0700, Linus Walleij wrote:
>> On Fri, Mar 4, 2016 at 5:59 PM, Matthias Brugger <mbrugger@suse.com>
>> wrote:
>>
>> > The standby GPIO controller can be used as a interrupt controller.
>> > Select GPIOLIB_IRQCHIP when compiling this driver. Otherwise we get
>> > a compilation error:
>> >
>> > drivers/gpio/gpio-xgene-sb.c: In function 'xgene_gpio_sb_probe':
>> > drivers/gpio/gpio-xgene-sb.c:312:10: error: 'struct gpio_chip' has
>> > no member named 'irqdomain'
>> >   priv->gc.irqdomain = priv->irq_domain;
>> >           ^
>> > scripts/Makefile.build:295: recipe for target 'drivers/gpio/gpio
>> > -xgene-sb.o' failed
>> > make[2]: *** [drivers/gpio/gpio-xgene-sb.o] Error 1
>> >
>> > Fixes: 1013fc41 "gpio: xgene: Enable X-Gene standby GPIO as
>> > interrupt controller"
>> > Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>>
>> Quan's patch exporting the symbols has been merged by tglx
>> so dropping this.
>>
>
> Thanks for the info.
>
> Actually this is v1 [1] of the patch, which just addresses the
> GPIOLIB_IRQCHIP problem?
> With Quan's patch this should still be present.

Ah sorry I screwed up here and confused the patches.

Patch applied.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web