Re: [RFC/RFT PATCH 0/2] mfd: max14577: Allow the driver to be built as a module

Path	csiph.com!aioe.org!news.servidellagleba.it!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [RFC/RFT PATCH 0/2] mfd: max14577: Allow the driver to be built as a module
Date	Thu, 17 Mar 2016 16:30:03 +0100
Message-ID	<rdI27-Gq-23@gated-at.bofh.it> (permalink)
References	<rdmNY-333-11@gated-at.bofh.it> <rduLv-jE-7@gated-at.bofh.it>
X-Original-To	Krzysztof Kozlowski <k.kozlowski@samsung.com>, linux-kernel@vger.kernel.org
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	Chanwoo Choi <cw00.choi@samsung.com>, Lee Jones <lee.jones@linaro.org>
X-Original-Date	Thu, 17 Mar 2016 12:22:58 -0300
X-Original-Message-ID	<56EACBD2.7060101@osg.samsung.com>
X-Original-References	<1458146930-2723-1-git-send-email-javier@osg.samsung.com> <56EA03D8.80004@samsung.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1359949

Show key headers only | View raw

Hello Krzysztof,

On 03/16/2016 10:09 PM, Krzysztof Kozlowski wrote:
> On 17.03.2016 01:48, Javier Martinez Canillas wrote:
>> Hello,
>>
>> This series is similar to [0] and allows the max14577 PMIC MFD driver to
>> be built as a module. Currently the Kconfig symbol for the driver is a
>> boolean but there isn't really a reason for this restriction.
>>
>> The patches have been just built tested because I don't have any of the
>> boards using this driver, so testing will be highly appreciated.
>>
> 
> Thanks for the patch (and checking of regulator users) but one of the
> reasons of putting this item on todo list was to check and test. The
> change itself is trivial, I could do it on myself, right? :) But the
> point is that it needs some testing...
>

Well, IMHO there is some value in posting a patch even if not tested
(provided that you make that clear like I did) since it is easier to
test a patch than write and test it ;)
 
> BR,
> Krzysztof
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC/RFT PATCH 0/2] mfd: max14577: Allow the driver to be built as a module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-16 17:50 +0100
  [RFC/RFT PATCH 1/2] mfd: max14577: Use module_init() instead of subsys_initcall() Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-16 17:50 +0100
  [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-16 17:50 +0100
    Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a  module Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-17 03:00 +0100
      Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a  module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-17 16:40 +0100
        Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a  module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-17 18:00 +0100
          Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a  module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-17 19:10 +0100
            Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a  module Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-18 09:00 +0100
              Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a  module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-18 12:00 +0100
  Re: [RFC/RFT PATCH 0/2] mfd: max14577: Allow the driver to be built as  a module Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-17 02:20 +0100
    Re: [RFC/RFT PATCH 0/2] mfd: max14577: Allow the driver to be built  as a module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-17 16:30 +0100

csiph-web