Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1359161

[RFC/RFT PATCH 1/2] mfd: max14577: Use module_init() instead of subsys_initcall()

Show all headers | View raw

The driver's init function is called at subsys init call level but the
dependencies provided by the driver are looked up by drivers that have
probe deferral support, so manual ordering of init calls isn't needed.

Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---
Hello,

I checked an the only users in mainline for this driver are the Exynos3250
Monk and Rinato boards. In both, only two regulators are used (safeout_reg
and motor_reg) and these are looked up by the drivers phy-samsung-usb2 and
regulator-haptic respectively, and both support probe deferral.

Best regards,
Javier

 drivers/mfd/max14577.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
index 2280b3fdcf68..6c245128ab2e 100644
--- a/drivers/mfd/max14577.c
+++ b/drivers/mfd/max14577.c
@@ -561,7 +561,7 @@ static int __init max14577_i2c_init(void)
 
 	return i2c_add_driver(&max14577_i2c_driver);
 }
-subsys_initcall(max14577_i2c_init);
+module_init(max14577_i2c_init);
 
 static void __exit max14577_i2c_exit(void)
 {
-- 
2.5.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC/RFT PATCH 0/2] mfd: max14577: Allow the driver to be built as a module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-16 17:50 +0100
  [RFC/RFT PATCH 1/2] mfd: max14577: Use module_init() instead of subsys_initcall() Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-16 17:50 +0100
  [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-16 17:50 +0100
    Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a  module Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-17 03:00 +0100
      Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a  module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-17 16:40 +0100
  Re: [RFC/RFT PATCH 0/2] mfd: max14577: Allow the driver to be built as  a module Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-17 02:20 +0100
    Re: [RFC/RFT PATCH 0/2] mfd: max14577: Allow the driver to be built  as a module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-17 16:30 +0100

csiph-web