Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a module

From	Chanwoo Choi <cw00.choi@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a module
Date	2016-03-18 09:00 +0100
Message-ID	<rdXu9-2C8-5@gated-at.bofh.it> (permalink)
References	(1 earlier) <rdmNZ-333-35@gated-at.bofh.it> <rdvoe-yw-9@gated-at.bofh.it> <rdIbL-Jr-1@gated-at.bofh.it> <rdJrb-1sp-1@gated-at.bofh.it> <rdKwX-2ml-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Javier,

On 2016년 03월 18일 03:02, Javier Martinez Canillas wrote:
> Hello Chanwoo
> 
> On 03/17/2016 01:57 PM, Javier Martinez Canillas wrote:
> 
> [snip]
> 
>>>
>>
>> Sorry again, this error goes away after I clean the build directory so it
>> does not happen without this patch-set. Now, I found what's the issue and
>> is that both the max14577 MFD and regulator drivers have the same object
>> file name so they both end being called max14577.ko.
>>
>> This confuses Kbuild and so in the modpost step, the exported symbols by
>> the MFD driver don't end into Module.symvers. This doesn't happen when
>> the driver is not a module since symbols come from the vmlinux binary.
>>
>> I'll post a patch to rename the regulator driver to max14577-regulator,
>> this will be necessary anyways to have max14577 as a module since Kbuild
>> also gets confused and don't copy both modules because have the same name.
>>
> 
> Patch is [0], could you please test the patch-series along with that one
> and provide your Tested-by? I plan to re-send this series once [0] lands.

I'll test it on next week and then reply.

Best Regards,
Chanwoo Choi

> 
>> Best regards,
>>
> 
> [0]: https://patchwork.kernel.org/patch/8613691/
> 
> Best regards,
>

Thread

[RFC/RFT PATCH 0/2] mfd: max14577: Allow the driver to be built as a module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-16 17:50 +0100
  [RFC/RFT PATCH 1/2] mfd: max14577: Use module_init() instead of subsys_initcall() Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-16 17:50 +0100
  [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-16 17:50 +0100
    Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a  module Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-17 03:00 +0100
      Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a  module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-17 16:40 +0100
        Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a  module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-17 18:00 +0100
          Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a  module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-17 19:10 +0100
            Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a  module Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-18 09:00 +0100
              Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a  module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-18 12:00 +0100
  Re: [RFC/RFT PATCH 0/2] mfd: max14577: Allow the driver to be built as  a module Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-17 02:20 +0100
    Re: [RFC/RFT PATCH 0/2] mfd: max14577: Allow the driver to be built  as a module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-17 16:30 +0100

csiph-web