Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers" broken

From	Jens Axboe <axboe@kernel.dk>
Newsgroups	linux.kernel
Subject	Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers" broken
Date	2016-03-12 22:20 +0100
Message-ID	<rbZ73-3NR-5@gated-at.bofh.it> (permalink)
References	(7 earlier) <rbSoV-7fy-1@gated-at.bofh.it> <rbSIi-7nR-7@gated-at.bofh.it> <rbSRX-7sY-5@gated-at.bofh.it> <rbT1D-7xk-1@gated-at.bofh.it> <rbXRE-2KY-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03/12/2016 12:51 PM, Linus Torvalds wrote:
> On Sat, Mar 12, 2016 at 6:39 AM, Ming Lei <tom.leiming@gmail.com> wrote:
>>
>> I am fine with either way, and I will prepare one patch and let Jens
>> decide.
>
> So guys, this needs to be done *now*.
>
> And Jens - this is the last time I believe you when you say late
> patches are required.
>
> The buggy patch that introduced this problem was part of that very
> late pull request that I already rejected once, and you then claimed
> was absolutely required.
>
> So the dicking around with the block layer stops *now*.
>
> Seriously. I'm pissed off.

Believe me, I'm as impressed as you are...

I've queued it up and will run it through testing and send it off later. 
I still think it's better to apply the fix, rather than revert the 
original change.

> I don't want to see anything even half-way questionable during the
> whole next release window. Not even during the merge window. You need
> to do some serious quality control, and re-think the whole "large
> changes" model.

The timing was the issue here, and yeah, it didn't work out well this 
time at all. It's a momentary lapse, we'll get it sorted for sure.

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

e827091cb1 "block: merge: get the 1st and last bvec via helpers"  broken Kent Overstreet <kent.overstreet@gmail.com> - 2016-03-12 08:50 +0100
  Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers" broken Ming Lin <mlin@kernel.org> - 2016-03-12 09:10 +0100
  Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers" broken Ming Lei <tom.leiming@gmail.com> - 2016-03-12 09:50 +0100
    Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers"  broken Kent Overstreet <kent.overstreet@gmail.com> - 2016-03-12 10:30 +0100
      Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers" broken Ming Lei <tom.leiming@gmail.com> - 2016-03-12 11:40 +0100
        Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers"  broken Kent Overstreet <kent.overstreet@gmail.com> - 2016-03-12 13:20 +0100
          Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers" broken Ming Lei <tom.leiming@gmail.com> - 2016-03-12 14:40 +0100
            Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers"  broken Kent Overstreet <kent.overstreet@gmail.com> - 2016-03-12 14:50 +0100
              Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers"  broken Kent Overstreet <kent.overstreet@gmail.com> - 2016-03-12 15:10 +0100
                Re: e827091cb1 "block: merge: get the 1st and last bvec via  helpers" broken Ming Lei <tom.leiming@gmail.com> - 2016-03-12 15:30 +0100
                Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers"  broken Kent Overstreet <kent.overstreet@gmail.com> - 2016-03-12 15:40 +0100
                Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers" broken Ming Lei <tom.leiming@gmail.com> - 2016-03-12 15:50 +0100
                Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers" broken Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-12 21:00 +0100
                Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers"  broken Jens Axboe <axboe@kernel.dk> - 2016-03-12 22:20 +0100

csiph-web