Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1356381

Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers" broken

From Ming Lei <tom.leiming@gmail.com>
Newsgroups linux.kernel
Subject Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers" broken
Date 2016-03-12 09:50 +0100
Message-ID <rbNpg-3hA-9@gated-at.bofh.it> (permalink)
References <rbMtb-2Fi-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Mar 12, 2016 at 3:43 PM, Kent Overstreet
<kent.overstreet@gmail.com> wrote:
> I don't know exactly how it's broken, but with that patch segment counting is
> broken - I'm seeing blk_rq_map_sg() overrun the end of the sgtable.
>
> I suggest reverting it for 4.5...

Kent, could you share your test case? I'd like to figure out the root cause.

BTW, I don't object to revert it given it is close to v4.5 release, but I am
curious how it breaks segment couting.


Thanks,
Ming Lei

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

e827091cb1 "block: merge: get the 1st and last bvec via helpers"  broken Kent Overstreet <kent.overstreet@gmail.com> - 2016-03-12 08:50 +0100
  Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers" broken Ming Lin <mlin@kernel.org> - 2016-03-12 09:10 +0100
  Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers" broken Ming Lei <tom.leiming@gmail.com> - 2016-03-12 09:50 +0100
    Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers"  broken Kent Overstreet <kent.overstreet@gmail.com> - 2016-03-12 10:30 +0100
      Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers" broken Ming Lei <tom.leiming@gmail.com> - 2016-03-12 11:40 +0100
        Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers"  broken Kent Overstreet <kent.overstreet@gmail.com> - 2016-03-12 13:20 +0100
          Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers" broken Ming Lei <tom.leiming@gmail.com> - 2016-03-12 14:40 +0100
            Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers"  broken Kent Overstreet <kent.overstreet@gmail.com> - 2016-03-12 14:50 +0100
              Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers"  broken Kent Overstreet <kent.overstreet@gmail.com> - 2016-03-12 15:10 +0100
                Re: e827091cb1 "block: merge: get the 1st and last bvec via  helpers" broken Ming Lei <tom.leiming@gmail.com> - 2016-03-12 15:30 +0100
                Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers"  broken Kent Overstreet <kent.overstreet@gmail.com> - 2016-03-12 15:40 +0100
                Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers" broken Ming Lei <tom.leiming@gmail.com> - 2016-03-12 15:50 +0100
                Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers" broken Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-12 21:00 +0100
                Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers"  broken Jens Axboe <axboe@kernel.dk> - 2016-03-12 22:20 +0100

csiph-web