Re: [PATCH 2/5] gpio: gpiolib: Print error number if gpio hog failed

From	Laxman Dewangan <ldewangan@nvidia.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/5] gpio: gpiolib: Print error number if gpio hog failed
Date	2016-03-08 16:50 +0100
Message-ID	<ras3w-2Le-27@gated-at.bofh.it> (permalink)
References	<raoMi-Hp-7@gated-at.bofh.it> <raoMi-Hp-9@gated-at.bofh.it> <raqO6-21z-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tuesday 08 March 2016 07:52 PM, Thierry Reding wrote:
> On Tue, Mar 08, 2016 at 05:32:05PM +0530, Laxman Dewangan wrote:
>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> ---
>>   drivers/gpio/gpiolib.c | 9 +++++----
>>   1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
>> index bc788b9..7575ebb 100644
>> --- a/drivers/gpio/gpiolib.c
>> +++ b/drivers/gpio/gpiolib.c
>> @@ -2621,15 +2621,16 @@ int gpiod_hog(struct gpio_desc *desc, const char *name,
>>   
>>   	local_desc = gpiochip_request_own_desc(chip, hwnum, name);
>>   	if (IS_ERR(local_desc)) {
>> -		pr_err("requesting hog GPIO %s (chip %s, offset %d) failed\n",
>> -		       name, chip->label, hwnum);
>> +		status = PTR_ERR(local_desc);
>> +		pr_err("requesting hog GPIO %s, chip %s, offset %d failed %d\n",
>> +		       name, chip->label, hwnum, status);
> I find this type of format hard to read. I prefer a semi-colon to
> separate the message from the failure reason (i.e. error code).
>
> Besides that I don't understand why you're dropping the parentheses
> around the "chip %s, offset %d", I found that easier on the eye.
>
>


I did to accommodate the  3 extra character ( %d) for string format on 
that line as it was already near to 80 column.
Just did not want to split in multiple lines.

Thread

[PATCH 2/5] gpio: gpiolib: Print error number if gpio hog failed Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-08 13:20 +0100
  Re: [PATCH 2/5] gpio: gpiolib: Print error number if gpio hog failed Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-03-08 13:30 +0100
  Re: [PATCH 2/5] gpio: gpiolib: Print error number if gpio hog failed Thierry Reding <treding@nvidia.com> - 2016-03-08 15:30 +0100
    Re: [PATCH 2/5] gpio: gpiolib: Print error number if gpio hog failed Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-08 16:50 +0100
      Re: [PATCH 2/5] gpio: gpiolib: Print error number if gpio hog failed Stephen Warren <swarren@wwwdotorg.org> - 2016-03-09 18:10 +0100
        Re: [PATCH 2/5] gpio: gpiolib: Print error number if gpio hog failed Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-10 08:20 +0100

csiph-web