[PATCH 2/5] gpio: gpiolib: Print error number if gpio hog failed

From	Laxman Dewangan <ldewangan@nvidia.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/5] gpio: gpiolib: Print error number if gpio hog failed
Date	2016-03-08 13:20 +0100
Message-ID	<raoMi-Hp-9@gated-at.bofh.it> (permalink)
References	<raoMi-Hp-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Print the error number of GPIO hog failed during
its configurations. This helps in identifying the
failure without instrumenting the code.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
 drivers/gpio/gpiolib.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index bc788b9..7575ebb 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -2621,15 +2621,16 @@ int gpiod_hog(struct gpio_desc *desc, const char *name,
 
 	local_desc = gpiochip_request_own_desc(chip, hwnum, name);
 	if (IS_ERR(local_desc)) {
-		pr_err("requesting hog GPIO %s (chip %s, offset %d) failed\n",
-		       name, chip->label, hwnum);
+		status = PTR_ERR(local_desc);
+		pr_err("requesting hog GPIO %s, chip %s, offset %d failed %d\n",
+		       name, chip->label, hwnum, status);
 		return PTR_ERR(local_desc);
 	}
 
 	status = gpiod_configure_flags(desc, name, dflags);
 	if (status < 0) {
-		pr_err("setup of hog GPIO %s (chip %s, offset %d) failed\n",
-		       name, chip->label, hwnum);
+		pr_err("setup of hog GPIO %s chip %s, offset %d failed %d\n",
+		       name, chip->label, hwnum, status);
 		gpiochip_free_own_desc(desc);
 		return status;
 	}
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/5] gpio: gpiolib: Print error number if gpio hog failed Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-08 13:20 +0100
  Re: [PATCH 2/5] gpio: gpiolib: Print error number if gpio hog failed Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-03-08 13:30 +0100
  Re: [PATCH 2/5] gpio: gpiolib: Print error number if gpio hog failed Thierry Reding <treding@nvidia.com> - 2016-03-08 15:30 +0100
    Re: [PATCH 2/5] gpio: gpiolib: Print error number if gpio hog failed Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-08 16:50 +0100
      Re: [PATCH 2/5] gpio: gpiolib: Print error number if gpio hog failed Stephen Warren <swarren@wwwdotorg.org> - 2016-03-09 18:10 +0100
        Re: [PATCH 2/5] gpio: gpiolib: Print error number if gpio hog failed Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-10 08:20 +0100

csiph-web