Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1452087

Re: [PATCH -next] PCI/PCIe: make DPC explicitly non-modular

Show all headers | View raw

On Thu, Jul 28, 2016 at 03:33:03PM -0400, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> drivers/pci/pcie/Kconfig:config PCIE_DPC
> drivers/pci/pcie/Kconfig:       bool "PCIe Downstream Port Containment support"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.

Thanks for cleaning this up.

FWIW, all of the other pcie service drivers look like they could use
the same cleanup.

Reviewed-by: Keith Busch <keith.busch@intel.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] PCI/PCIe: make DPC explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-28 21:40 +0200
  Re: [PATCH -next] PCI/PCIe: make DPC explicitly non-modular Keith Busch <keith.busch@intel.com> - 2016-07-28 22:20 +0200
    Re: [PATCH -next] PCI/PCIe: make DPC explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-28 23:30 +0200

csiph-web