Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1452086
| From | Rich Felker <dalias@libc.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v5 2/2] clocksource: add J-Core timer/clocksource driver |
| Date | 2016-07-28 22:10 +0200 |
| Message-ID | <rZZMZ-2Fu-17@gated-at.bofh.it> (permalink) |
| References | <rZNC9-2Rd-5@gated-at.bofh.it> <rZNC9-2Rd-21@gated-at.bofh.it> <rZUNj-7Ak-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jul 28, 2016 at 04:44:05PM +0200, Thomas Gleixner wrote:
> > +static int jcore_pit_cpu_notify(struct notifier_block *self,
> > + unsigned long action, void *hcpu)
> > +{
> > + struct jcore_pit_nb *nb = container_of(self, struct jcore_pit_nb, nb);
> > + switch (action & ~CPU_TASKS_FROZEN) {
> > + case CPU_STARTING:
> > + jcore_pit_local_init(this_cpu_ptr(nb->pit_percpu));
> > + break;
> > + }
> > + return NOTIFY_OK;
>
> Please convert this to the new state machine model of cpu
> hotplug. CPU_STARTING will be gone very soon. Here is an example:
>
> http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=smp/hotplug&id=7e86e8bd8dd67649d176e08d8dfb90039f0a1e98
Trying this change now and I'm getting hangs inside
cpuhp_invoke_ap_callback between wake_up_process and
wait_for_completion. I suspect it's not possible to run a scheduled
task yet because there's no timer yet, or something like that. Do I
need further infrastructure from tip that's not upstream yet in order
to test this? I just rebased on linus/master and still have the same
problem, but none of the other driver changes are in Linus's tree yet.
Following the other drivers in tip (again, I don't have any of these
in my tree), I put the new state between CPUHP_AP_SCHED_STARTING and
CPUHP_AP_NOTIFY_STARTING; is this correct?
Rich
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v5 0/2] J-Core timer support Rich Felker <dalias@libc.org> - 2016-07-28 09:10 +0200
[PATCH v5 2/2] clocksource: add J-Core timer/clocksource driver Rich Felker <dalias@libc.org> - 2016-07-28 09:10 +0200
Re: [PATCH v5 2/2] clocksource: add J-Core timer/clocksource driver Thomas Gleixner <tglx@linutronix.de> - 2016-07-28 16:50 +0200
Re: [PATCH v5 2/2] clocksource: add J-Core timer/clocksource driver Rich Felker <dalias@libc.org> - 2016-07-28 18:40 +0200
Re: [PATCH v5 2/2] clocksource: add J-Core timer/clocksource driver Thomas Gleixner <tglx@linutronix.de> - 2016-07-28 18:50 +0200
Re: [PATCH v5 2/2] clocksource: add J-Core timer/clocksource driver Rich Felker <dalias@libc.org> - 2016-07-28 21:40 +0200
Re: [PATCH v5 2/2] clocksource: add J-Core timer/clocksource driver Rich Felker <dalias@libc.org> - 2016-07-28 22:10 +0200
Re: [PATCH v5 2/2] clocksource: add J-Core timer/clocksource driver Rich Felker <dalias@libc.org> - 2016-07-28 22:20 +0200
Re: [PATCH v5 2/2] clocksource: add J-Core timer/clocksource driver Rich Felker <dalias@libc.org> - 2016-07-31 18:10 +0200
[PATCH v5 1/2] of: add J-Core timer bindings Rich Felker <dalias@libc.org> - 2016-07-28 09:10 +0200
Re: [PATCH v5 1/2] of: add J-Core timer bindings Rob Herring <robh@kernel.org> - 2016-07-29 23:00 +0200
Re: [PATCH v5 1/2] of: add J-Core timer bindings Rich Felker <dalias@libc.org> - 2016-08-03 01:00 +0200
csiph-web