Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1452088

Re: [GIT PULL] configfs updates for 4.8

Show all headers | View raw

On Thu, Jul 28, 2016 at 01:05:13PM -0700, Linus Torvalds wrote:
> On Thu, Jul 28, 2016 at 6:30 AM, Christoph Hellwig <hch@infradead.org> wrote:
> >
> >   git://git.infradead.org/users/hch/configfs.git tags/configfs-for-4.8
> >
> > for you to fetch changes up to 3dc3afadeb0403fd967b97ee282ab9053d36da2b:
> 
> Same lack of diffstat..
> 
> There's a reason we have a "git request-pull" helper. You don't have
> to use it (lots of people end up using other things that match their
> workflow better), but you do have to generate something at least as
> good at that.

FWIW, git request-pull is very likely to make complete mess of
diffstat - all it takes is branch started at -rc1, then a merge from
anything started at later point (e.g. Miklos asking to pull ->d_real()
work from his tree into vfs.git, with his branch starting at -rc5).

I've ended up doing git fetch origin; git checkout -b XXX origin; git
merge work.misc; git diff XXX --stat and replacing the mess produced by
git-request-pull with that.  It works, of course, but what worries me
is that less obvious mess could've slipped unnoticed.  Might make sense
to teach git request-pull to warn about likely bogus diffstat...

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL] configfs updates for 4.8 Christoph Hellwig <hch@infradead.org> - 2016-07-28 15:40 +0200
  Re: [GIT PULL] configfs updates for 4.8 Linus Torvalds <torvalds@linux-foundation.org> - 2016-07-28 22:10 +0200
    Re: [GIT PULL] configfs updates for 4.8 Al Viro <viro@ZenIV.linux.org.uk> - 2016-07-28 22:20 +0200
      Re: [GIT PULL] configfs updates for 4.8 Linus Torvalds <torvalds@linux-foundation.org> - 2016-07-28 22:30 +0200
        Re: [GIT PULL] configfs updates for 4.8 James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-07-29 00:10 +0200
    Re: [GIT PULL] configfs updates for 4.8 Christoph Hellwig <hch@infradead.org> - 2016-07-29 09:20 +0200
      Re: [GIT PULL] configfs updates for 4.8 Christoph Hellwig <hch@infradead.org> - 2016-07-29 10:00 +0200
  [GIT PULL] configfs updates for 4.8 Christoph Hellwig <hch@infradead.org> - 2016-07-29 10:00 +0200

csiph-web