Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1450404
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: staging: wilc1000: Reduce scope for a few variables in mac_ioctl() |
| Date | 2016-07-26 08:30 +0200 |
| Message-ID | <rZ42m-6Xo-1@gated-at.bofh.it> (permalink) |
| References | <rYTzY-8r9-33@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
>> - if (strncasecmp(buff, "RSSI", length) == 0) {
>> + if (strncasecmp(buff, "RSSI", 0) == 0) {
>> + s8 rssi;
>> +
>
> Um, please think a second about if it makes any sense at all to compare
> zero chars of two strings.
Under which circumstances should the variable "length" contain an other
value than zero?
How can this open issue be fixed better?
Regards,
Markus
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 3/3] staging: wilc1000: Reduce scope for a few variables in mac_ioctl() Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-07-25 21:20 +0200
Re: [PATCH 3/3] staging: wilc1000: Reduce scope for a few variables in mac_ioctl() walter harms <wharms@bfs.de> - 2016-07-25 21:40 +0200
Re: staging: wilc1000: Reduce scope for a few variables in mac_ioctl() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-26 08:30 +0200
Aw: Re: staging: wilc1000: Reduce scope for a few variables in mac_ioctl() "Lino Sanfilippo" <LinoSanfilippo@gmx.de> - 2016-07-28 13:50 +0200
Re: staging: wilc1000: Reduce scope for a few variables in mac_ioctl() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-28 18:10 +0200
csiph-web