Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1450405
| From | <SebastienOcquidant@Eaton.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH 4.6 143/203] memory: omap-gpmc: Fix omap gpmc EXTRADELAY timing |
| Date | 2016-07-26 08:30 +0200 |
| Message-ID | <rZ42m-6Xo-3@gated-at.bofh.it> (permalink) |
| References | <rYVs7-1c6-53@gated-at.bofh.it> <rYW4N-1xV-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
----------------------------- Eaton Industries (France) S.A.S ~ Siège social: 110 Rue Blaise Pascal, Immeuble Le Viséo - Bâtiment A Innovallée, 38330, Montbonnot-St.-Martin, France ~ Lieu d'enregistrement au registre du commerce: Grenoble ~ Numéro d'enregistrement: 509 653 176 ~ Capital social souscrit et liberé:€ 16215441 ~ Numéro de TVA: FR47509653176 ----------------------------- -----Message d'origine----- De : Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org] Envoyé : lundi 25 juillet 2016 22:56 À : linux-kernel@vger.kernel.org Cc : Greg Kroah-Hartman; stable@vger.kernel.org; Ocquidant, Sebastien; Roger Quadros Objet : [PATCH 4.6 143/203] memory: omap-gpmc: Fix omap gpmc EXTRADELAY timing 4.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ocquidant, Sebastien <sebastienocquidant@eaton.com> commit 8f50b8e57442d28e41bb736c173d8a2490549a82 upstream. In the omap gpmc driver it can be noticed that GPMC_CONFIG4_OEEXTRADELAY is overwritten by the WEEXTRADELAY value from the device tree and GPMC_CONFIG4_WEEXTRADELAY is not updated by the value from the device tree. As a consequence, the memory accesses cannot be configured properly when the extra delay are needed for OE and WE. Fix the update of GPMC_CONFIG4_WEEXTRADELAY with the value from the device tree file and prevents GPMC_CONFIG4_OEXTRADELAY being overwritten by the WEXTRADELAY value from the device tree. Signed-off-by: Ocquidant, Sebastien <sebastienocquidant@eaton.com> Signed-off-by: Roger Quadros <rogerq@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/memory/omap-gpmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/memory/omap-gpmc.c +++ b/drivers/memory/omap-gpmc.c @@ -394,7 +394,7 @@ static void gpmc_cs_bool_timings(int cs, gpmc_cs_modify_reg(cs, GPMC_CS_CONFIG4, GPMC_CONFIG4_OEEXTRADELAY, p->oe_extra_delay); gpmc_cs_modify_reg(cs, GPMC_CS_CONFIG4, - GPMC_CONFIG4_OEEXTRADELAY, p->we_extra_delay); + GPMC_CONFIG4_WEEXTRADELAY, p->we_extra_delay); gpmc_cs_modify_reg(cs, GPMC_CS_CONFIG6, GPMC_CONFIG6_CYCLE2CYCLESAMECSEN, p->cycle2cyclesamecsen); ======================================================================================== Hi Greg, OK for me Sébastien Ocquidant
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 4.6 143/203] memory: omap-gpmc: Fix omap gpmc EXTRADELAY timing Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-07-26 00:00 +0200 RE: [PATCH 4.6 143/203] memory: omap-gpmc: Fix omap gpmc EXTRADELAY timing <SebastienOcquidant@Eaton.com> - 2016-07-26 08:30 +0200
csiph-web