Groups > linux.kernel > #1451995

Re: staging: wilc1000: Reduce scope for a few variables in mac_ioctl()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	Re: staging: wilc1000: Reduce scope for a few variables in mac_ioctl()
Date	2016-07-28 18:10 +0200
Message-ID	<rZW2J-b8-7@gated-at.bofh.it> (permalink)
References	<rYTzY-8r9-33@gated-at.bofh.it> <rZ42m-6Xo-1@gated-at.bofh.it> <rZRZ8-5HN-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> Which circumstances do "not any sense at all" imply? 

Should the expression 'strlen("RSSI")' be passed for the parameter 'length' instead?


> I suggest to fix this since it is indeed a bug,

We can agree that this function implementation was broken for a while there.


> instead of doing "micro optimizations" - which is the last thing that code in the staging area 
> needs (as IIRC you have already been told by others, including the staging maintainer).

The acceptance might grow a bit more for such software fine-tuning
(like refactoring around variable usage).

Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: staging: wilc1000: Reduce scope for a few variables in  mac_ioctl() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-26 08:30 +0200
  Aw: Re: staging: wilc1000: Reduce scope for a few variables in  mac_ioctl() "Lino Sanfilippo" <LinoSanfilippo@gmx.de> - 2016-07-28 13:50 +0200
    Re: staging: wilc1000: Reduce scope for a few variables in  mac_ioctl() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-28 18:10 +0200

csiph-web