Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1439408
| From | "Jan Beulich" <JBeulich@suse.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 1/4] xenbus: prefer xenbus_scanf() over xenbus_gather() |
| Date | 2016-07-08 14:30 +0200 |
| Message-ID | <rSD4T-4Jb-45@gated-at.bofh.it> (permalink) |
| References | <rSD4S-4Jb-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
For single items being collected this should be preferred as being more
typesafe (as the compiler can check format string and to-be-written-to
variable match) and more efficient (requiring one less parameter to be
passed).
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Avoid commit message to continue from subject.
---
drivers/xen/xenbus/xenbus_client.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- 4.7-rc6-prefer-xenbus_scanf.orig/drivers/xen/xenbus/xenbus_client.c
+++ 4.7-rc6-prefer-xenbus_scanf/drivers/xen/xenbus/xenbus_client.c
@@ -926,9 +926,9 @@ EXPORT_SYMBOL_GPL(xenbus_unmap_ring);
*/
enum xenbus_state xenbus_read_driver_state(const char *path)
{
- enum xenbus_state result;
- int err = xenbus_gather(XBT_NIL, path, "state", "%d", &result, NULL);
- if (err)
+ int result;
+
+ if (xenbus_scanf(XBT_NIL, path, "state", "%d", &result) != 1)
result = XenbusStateUnknown;
return result;
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather() "Jan Beulich" <JBeulich@suse.com> - 2016-07-08 14:30 +0200
[PATCH v2 3/4] xen-blkfront: prefer xenbus_scanf() over xenbus_gather() "Jan Beulich" <JBeulich@suse.com> - 2016-07-08 14:30 +0200
[PATCH v2 1/4] xenbus: prefer xenbus_scanf() over xenbus_gather() "Jan Beulich" <JBeulich@suse.com> - 2016-07-08 14:30 +0200
[PATCH v2 2/4] xen-blkback: prefer xenbus_scanf() over xenbus_gather() "Jan Beulich" <JBeulich@suse.com> - 2016-07-08 14:30 +0200
Re: [Xen-devel] [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather() Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2016-07-08 16:20 +0200
Re: [Xen-devel] [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather() "Jan Beulich" <JBeulich@suse.com> - 2016-07-08 17:10 +0200
Re: [Xen-devel] [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather() Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2016-07-08 17:20 +0200
Re: [Xen-devel] [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather() David Vrabel <david.vrabel@citrix.com> - 2016-07-08 17:50 +0200
Re: [Xen-devel] [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather() Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2016-07-08 18:00 +0200
csiph-web