Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1439407

Re: [PATCH v2 2/2] x86/acpi: Remove the repeated lapic address override entry parsing

From Ingo Molnar <mingo@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 2/2] x86/acpi: Remove the repeated lapic address override entry parsing
Date 2016-07-08 14:30 +0200
Message-ID <rSD4T-4Jb-43@gated-at.bofh.it> (permalink)
References <rOOrT-7eT-1@gated-at.bofh.it> <rOOrT-7eT-5@gated-at.bofh.it> <rPFcS-79h-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


* Baoquan He <bhe@redhat.com> wrote:

> ACPI MADT has a 32-bit field providing lapic address at which
> each processor can access its lapic information. MADT also contains
> an optional entry to provide a 64-bit address to override the 32-bit
> one. However the current code does the lapic address override entry
> parsing twice. One is in early_acpi_boot_init() because AMD NUMA need
> get boot_cpu_id earlier. The other is in acpi_boot_init() which parses
> all MADT entries.
> 
> So in this patch remove the repeated code in the 2nd part. Meanwhile
> print lapic override entry information like other MADT entry.

So this patch is not supposed to change behavior (modulo kernel messages), right? 
If so it would make sense to spell that out explicitly in the changelog.

Thanks,

	Ingo

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] x86/mm/numa: Open code function early_get_boot_cpu_id Baoquan He <bhe@redhat.com> - 2016-06-28 01:50 +0200
  [PATCH 2/2] x86/acpi: Remove the repeated lapic address override entry parsing Baoquan He <bhe@redhat.com> - 2016-06-28 01:50 +0200
    Re: [PATCH 2/2] x86/acpi: Remove the repeated lapic address override entry parsing "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-28 03:30 +0200
      Re: [PATCH 2/2] x86/acpi: Remove the repeated lapic address override  entry parsing Baoquan He <bhe@redhat.com> - 2016-06-28 05:40 +0200
    [PATCH v2 2/2] x86/acpi: Remove the repeated lapic address override  entry parsing Baoquan He <bhe@redhat.com> - 2016-06-30 10:10 +0200
      Re: [PATCH v2 2/2] x86/acpi: Remove the repeated lapic address  override entry parsing Ingo Molnar <mingo@kernel.org> - 2016-07-08 14:30 +0200
        Re: [PATCH v2 2/2] x86/acpi: Remove the repeated lapic address  override entry parsing Baoquan He <bhe@redhat.com> - 2016-07-08 15:00 +0200
        Re: [PATCH v2 2/2] x86/acpi: Remove the repeated lapic address  override entry parsing Baoquan He <bhe@redhat.com> - 2016-07-09 04:10 +0200

csiph-web