Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer

From	Graeme Gregory <gg@slimlogic.co.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer
Date	2016-07-05 16:20 +0200
Message-ID	<rRzmL-3UP-17@gated-at.bofh.it> (permalink)
References	<rPsfD-7yY-1@gated-at.bofh.it> <rPKPg-284-35@gated-at.bofh.it> <rQ8yd-8iZ-9@gated-at.bofh.it> <rQdHA-2R6-25@gated-at.bofh.it> <rRbDI-5I7-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jul 04, 2016 at 02:53:20PM +0200, Rafael J. Wysocki wrote:
> On Fri, Jul 1, 2016 at 11:04 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > On Friday, July 01, 2016 04:23:40 PM Will Deacon wrote:
> >> On Thu, Jun 30, 2016 at 09:48:02PM +0800, Hanjun Guo wrote:
> >> > On 2016/6/30 21:27, Rafael J. Wysocki wrote:
> >> > >On Thursday, June 30, 2016 10:10:02 AM Hanjun Guo wrote:
> >> > >>GTDT is part of ACPI spec, drivers/acpi/ is for driver code of
> >> > >>ACPI spec, I think it can stay in drivers/acpi/ from this point
> >> > >>of view, am I right?
> >> > >
> >> > >The question is not "Can it?", but "Does it need to?".
> >> > >
> >> > >It is in the spec, but still there's only one architecture needing it.
> >> > >
> >> > >There is no way to test it on any other architecture and no reason to build it
> >> > >for any other architecture, so why does it need to be located in drivers/acpi/ ?
> >> >
> >> > I'm fine to move it to other places such as arch/arm64/kernel/, but I
> >> > would like to ask ARM64 maintainer's suggestion for this.
> >> >
> >> > Will, Catalin, what's your opinion on this?
> >>
> >> We don't have any device-tree code for the architected timer under
> >> arch/arm64, so I don't see why we should need anything for ACPI either.
> >
> > And I don't see a reason for the GTDT code to be there in drivers/acpi/.
> >
> > What gives?
> 
> Well, since there are things like acpi_lpss in there, my position here
> is kind of weak. :-)
> 
> That said I'm not particularly happy with having them in
> drivers/acpi/, so I definitely won't object against attempts to moving
> them somewhere else.
> 
> > Maybe it should go to the same place as the analogus DT code, then?
> 
> I'm mostly concerned about how (and by whom) that code is going to be
> maintained going forward, though.  I also think it should be made
> clear that it is ARM64-only.
> 

So is this a documentation issue in which case Fu Wei can add that to
the file to explain its limited to ARM64. Or we could even rename the
file acpi_arm64_gtdt.c

It seems a pity as the comment on this series were minors to block
things on a filename/location.

Graeme

Thread

[PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 06/10] acpi: Add GTDT driver to kernel build system fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 04/10] acpi: Add some basic struct and functions in GTDT driver fu.wei@linaro.org - 2016-06-29 20:20 +0200
    Re: [PATCH v6 04/10] acpi: Add some basic struct and functions in  GTDT driver "Rafael J. Wysocki" <rafael@kernel.org> - 2016-06-29 23:30 +0200
      Re: [PATCH v6 04/10] acpi: Add some basic struct and functions in  GTDT driver Fu Wei <fu.wei@linaro.org> - 2016-06-30 03:20 +0200
        Re: [PATCH v6 04/10] acpi: Add some basic struct and functions in GTDT driver "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-30 03:30 +0200
          Re: [PATCH v6 04/10] acpi: Add some basic struct and functions in  GTDT driver Fu Wei <fu.wei@linaro.org> - 2016-06-30 03:40 +0200
          Re: [PATCH v6 04/10] acpi: Add some basic struct and functions in  GTDT driver Timur Tabi <timur@codeaurora.org> - 2016-06-30 06:20 +0200
  [PATCH v6 09/10] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 05/10] acpi: Add arch_timer support in GTDT table parse driver fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 01/10] clocksource/drivers/arm_arch_timer: Move enums and defines to header file fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 08/10] acpi: Add memory-mapped timer support in GTDT driver fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 07/10] clocksource/drivers/arm_arch_timer: Simplify ACPI support code. fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 03/10] clocksource/drivers/arm_arch_timer: Improve printk relevant code fu.wei@linaro.org - 2016-06-29 20:20 +0200
    Re: [PATCH v6 03/10] clocksource/drivers/arm_arch_timer: Improve  printk relevant code Hanjun Guo <hanjun.guo@linaro.org> - 2016-06-30 05:00 +0200
      Re: [PATCH v6 03/10] clocksource/drivers/arm_arch_timer: Improve  printk relevant code Fu Wei <fu.wei@linaro.org> - 2016-07-07 18:20 +0200
  [PATCH v6 02/10] clocksource/drivers/arm_arch_timer: Add a new enum for spi type fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 10/10] acpi: Add SBSA Generic Watchdog support in GTDT driver fu.wei@linaro.org - 2016-06-29 20:30 +0200
  Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer "Rafael J. Wysocki" <rafael@kernel.org> - 2016-06-29 23:40 +0200
    Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Fu Wei <fu.wei@linaro.org> - 2016-06-30 03:40 +0200
      Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-30 03:40 +0200
        Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Hanjun Guo <hanjun.guo@linaro.org> - 2016-06-30 04:20 +0200
          Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-30 15:30 +0200
            Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Hanjun Guo <hanjun.guo@linaro.org> - 2016-06-30 16:10 +0200
              Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Will Deacon <will.deacon@arm.com> - 2016-07-01 17:30 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-01 23:00 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer "Rafael J. Wysocki" <rafael@kernel.org> - 2016-07-04 15:00 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Graeme Gregory <gg@slimlogic.co.uk> - 2016-07-05 16:20 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer "Rafael J. Wysocki" <rafael@kernel.org> - 2016-07-06 02:10 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Hanjun Guo <hanjun.guo@linaro.org> - 2016-07-07 13:20 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-07 14:00 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-07-07 15:40 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-07 16:00 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Fu Wei <fu.wei@linaro.org> - 2016-07-07 17:30 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-07-08 15:30 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Sudeep Holla <sudeep.holla@arm.com> - 2016-07-08 16:00 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Hanjun Guo <hanjun.guo@linaro.org> - 2016-07-09 05:50 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Hanjun Guo <hanjun.guo@linaro.org> - 2016-07-09 05:10 +0200
            Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-07-01 16:10 +0200
              Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-01 23:00 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-07-04 15:50 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer "Rafael J. Wysocki" <rafael@kernel.org> - 2016-07-04 16:20 +0200

csiph-web