Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer

From	Hanjun Guo <hanjun.guo@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer
Date	2016-06-30 16:10 +0200
Message-ID	<rPKPg-284-35@gated-at.bofh.it> (permalink)
References	<rPsfD-7yY-1@gated-at.bofh.it> <rPz7r-3cj-13@gated-at.bofh.it> <rPzK9-3Lo-1@gated-at.bofh.it> <rPKcy-1EL-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2016/6/30 21:27, Rafael J. Wysocki wrote:
> On Thursday, June 30, 2016 10:10:02 AM Hanjun Guo wrote:
>> Hi Rafael,
>>
>> On 2016/6/30 9:37, Rafael J. Wysocki wrote:
>>> On Thursday, June 30, 2016 09:29:59 AM Fu Wei wrote:
>>>> Hi Rafael,
>>>>
>>>> On 30 June 2016 at 05:32, Rafael J. Wysocki <rafael@kernel.org> wrote:
>>>>> On Wed, Jun 29, 2016 at 8:15 PM,  <fu.wei@linaro.org> wrote:
>>>>>> From: Fu Wei <fu.wei@linaro.org>
>>>>>>
>>>>>> This patchset:
>>>>>>     (1)Preparation for adding GTDT support in arm_arch_timer
>>>>>>         1. Move some enums and marcos to header file
>>>>>>         2. Add a new enum for spi type.
>>>>>>         3. Improve printk relevant code
>>>>>>
>>>>>>     (2)Introduce ACPI GTDT parser: drivers/acpi/gtdt.c
>>>>>>     Parse all kinds of timer in GTDT table of ACPI:arch timer,
>>>>>>     memory-mapped timer and SBSA Generic Watchdog timer.
>>>>>>     This driver can help to simplify all the relevant timer drivers,
>>>>>>     and separate all the ACPI GTDT knowledge from them.
>>>>>>
>>>>>>     (3)Simplify ACPI code for arm_arch_timer
>>>>>>
>>>>>>     (4)Add GTDT support for ARM memory-mapped timer
>>>>>
>>>>> GTDT is ARM-specific AFAICS.
>>>>
>>>> yes, you are right, it is.
>>>>
>>>>>
>>>>> If so, why do we need that code to reside in drivers/acpi/ ?
>>>>
>>>> Although  the GTDT is just for ARM64, but this driver is parsing one
>>>> of ACPI table,
>>>> I think that could be treated as ACPI driver.  Do I miss something? :-)
>>>
>>> Yes, you are.  Nobody except for ARM64 will ever need it.
>>
>> GTDT is part of ACPI spec, drivers/acpi/ is for driver code of
>> ACPI spec, I think it can stay in drivers/acpi/ from this point
>> of view, am I right?
>
> The question is not "Can it?", but "Does it need to?".
>
> It is in the spec, but still there's only one architecture needing it.
>
> There is no way to test it on any other architecture and no reason to build it
> for any other architecture, so why does it need to be located in drivers/acpi/ ?

I'm fine to move it to other places such as arch/arm64/kernel/, but I
would like to ask ARM64 maintainer's suggestion for this.

Will, Catalin, what's your opinion on this?

Thanks
Hanjun

Thread

[PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 06/10] acpi: Add GTDT driver to kernel build system fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 04/10] acpi: Add some basic struct and functions in GTDT driver fu.wei@linaro.org - 2016-06-29 20:20 +0200
    Re: [PATCH v6 04/10] acpi: Add some basic struct and functions in  GTDT driver "Rafael J. Wysocki" <rafael@kernel.org> - 2016-06-29 23:30 +0200
      Re: [PATCH v6 04/10] acpi: Add some basic struct and functions in  GTDT driver Fu Wei <fu.wei@linaro.org> - 2016-06-30 03:20 +0200
        Re: [PATCH v6 04/10] acpi: Add some basic struct and functions in GTDT driver "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-30 03:30 +0200
          Re: [PATCH v6 04/10] acpi: Add some basic struct and functions in  GTDT driver Fu Wei <fu.wei@linaro.org> - 2016-06-30 03:40 +0200
          Re: [PATCH v6 04/10] acpi: Add some basic struct and functions in  GTDT driver Timur Tabi <timur@codeaurora.org> - 2016-06-30 06:20 +0200
  [PATCH v6 09/10] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 05/10] acpi: Add arch_timer support in GTDT table parse driver fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 01/10] clocksource/drivers/arm_arch_timer: Move enums and defines to header file fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 08/10] acpi: Add memory-mapped timer support in GTDT driver fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 07/10] clocksource/drivers/arm_arch_timer: Simplify ACPI support code. fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 03/10] clocksource/drivers/arm_arch_timer: Improve printk relevant code fu.wei@linaro.org - 2016-06-29 20:20 +0200
    Re: [PATCH v6 03/10] clocksource/drivers/arm_arch_timer: Improve  printk relevant code Hanjun Guo <hanjun.guo@linaro.org> - 2016-06-30 05:00 +0200
      Re: [PATCH v6 03/10] clocksource/drivers/arm_arch_timer: Improve  printk relevant code Fu Wei <fu.wei@linaro.org> - 2016-07-07 18:20 +0200
  [PATCH v6 02/10] clocksource/drivers/arm_arch_timer: Add a new enum for spi type fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 10/10] acpi: Add SBSA Generic Watchdog support in GTDT driver fu.wei@linaro.org - 2016-06-29 20:30 +0200
  Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer "Rafael J. Wysocki" <rafael@kernel.org> - 2016-06-29 23:40 +0200
    Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Fu Wei <fu.wei@linaro.org> - 2016-06-30 03:40 +0200
      Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-30 03:40 +0200
        Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Hanjun Guo <hanjun.guo@linaro.org> - 2016-06-30 04:20 +0200
          Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-30 15:30 +0200
            Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Hanjun Guo <hanjun.guo@linaro.org> - 2016-06-30 16:10 +0200
              Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Will Deacon <will.deacon@arm.com> - 2016-07-01 17:30 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-01 23:00 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer "Rafael J. Wysocki" <rafael@kernel.org> - 2016-07-04 15:00 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Graeme Gregory <gg@slimlogic.co.uk> - 2016-07-05 16:20 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer "Rafael J. Wysocki" <rafael@kernel.org> - 2016-07-06 02:10 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Hanjun Guo <hanjun.guo@linaro.org> - 2016-07-07 13:20 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-07 14:00 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-07-07 15:40 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-07 16:00 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Fu Wei <fu.wei@linaro.org> - 2016-07-07 17:30 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-07-08 15:30 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Sudeep Holla <sudeep.holla@arm.com> - 2016-07-08 16:00 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Hanjun Guo <hanjun.guo@linaro.org> - 2016-07-09 05:50 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Hanjun Guo <hanjun.guo@linaro.org> - 2016-07-09 05:10 +0200
            Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-07-01 16:10 +0200
              Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-01 23:00 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-07-04 15:50 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer "Rafael J. Wysocki" <rafael@kernel.org> - 2016-07-04 16:20 +0200

csiph-web