Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1435622

Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer

Show all headers | View raw

On Friday, July 01, 2016 04:00:34 PM Daniel Lezcano wrote:
> On 06/30/2016 03:27 PM, Rafael J. Wysocki wrote:
> 
> [ ... ]
> 
> >> GTDT is part of ACPI spec, drivers/acpi/ is for driver code of
> >> ACPI spec, I think it can stay in drivers/acpi/ from this point
> >> of view, am I right?
> >
> > The question is not "Can it?", but "Does it need to?".
> >
> > It is in the spec, but still there's only one architecture needing it.
> >
> > There is no way to test it on any other architecture and no reason to build it
> > for any other architecture, so why does it need to be located in drivers/acpi/ ?
> 
> Hi Rafael,
> 
> what is the problem of having it in drivers/acpi ?

There's no reason for it to be there.

> There are cpufreq-dt, speedstep*, tegra124-* in drivers/cpufreq.

Yes, they are, but for a reason.  Having them in there makes it easier to
rework and clean up the core.

> clocksource-probe which is DT based with different drivers using it in 
> drivers/clocksource with a pletore of different archs.

So maybe the GTDT code should be there too?

> Cstate code which is only used by x86 is in drivers/acpi, it is only 
> used by x86/ia64 and it isn't a problem.

It is a problem.  drivers/acpi/ is not the right place for arch-specific code.

> There is a small chunk in arch/x86/kernel/acpi and it doesn't facilitate the
> comprehension of the code.
> 
> IMHO, having all ACPI code in the same directory will encourage the 
> consolidation.

The consolidation of what exactly?

In particular, how does the GTDT code in drivers/acpi/ help to consolidate
anything?

Thanks,
Rafael

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 06/10] acpi: Add GTDT driver to kernel build system fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 04/10] acpi: Add some basic struct and functions in GTDT driver fu.wei@linaro.org - 2016-06-29 20:20 +0200
    Re: [PATCH v6 04/10] acpi: Add some basic struct and functions in  GTDT driver "Rafael J. Wysocki" <rafael@kernel.org> - 2016-06-29 23:30 +0200
      Re: [PATCH v6 04/10] acpi: Add some basic struct and functions in  GTDT driver Fu Wei <fu.wei@linaro.org> - 2016-06-30 03:20 +0200
        Re: [PATCH v6 04/10] acpi: Add some basic struct and functions in GTDT driver "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-30 03:30 +0200
          Re: [PATCH v6 04/10] acpi: Add some basic struct and functions in  GTDT driver Fu Wei <fu.wei@linaro.org> - 2016-06-30 03:40 +0200
          Re: [PATCH v6 04/10] acpi: Add some basic struct and functions in  GTDT driver Timur Tabi <timur@codeaurora.org> - 2016-06-30 06:20 +0200
  [PATCH v6 09/10] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 05/10] acpi: Add arch_timer support in GTDT table parse driver fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 01/10] clocksource/drivers/arm_arch_timer: Move enums and defines to header file fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 08/10] acpi: Add memory-mapped timer support in GTDT driver fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 07/10] clocksource/drivers/arm_arch_timer: Simplify ACPI support code. fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 03/10] clocksource/drivers/arm_arch_timer: Improve printk relevant code fu.wei@linaro.org - 2016-06-29 20:20 +0200
    Re: [PATCH v6 03/10] clocksource/drivers/arm_arch_timer: Improve  printk relevant code Hanjun Guo <hanjun.guo@linaro.org> - 2016-06-30 05:00 +0200
      Re: [PATCH v6 03/10] clocksource/drivers/arm_arch_timer: Improve  printk relevant code Fu Wei <fu.wei@linaro.org> - 2016-07-07 18:20 +0200
  [PATCH v6 02/10] clocksource/drivers/arm_arch_timer: Add a new enum for spi type fu.wei@linaro.org - 2016-06-29 20:20 +0200
  [PATCH v6 10/10] acpi: Add SBSA Generic Watchdog support in GTDT driver fu.wei@linaro.org - 2016-06-29 20:30 +0200
  Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer "Rafael J. Wysocki" <rafael@kernel.org> - 2016-06-29 23:40 +0200
    Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Fu Wei <fu.wei@linaro.org> - 2016-06-30 03:40 +0200
      Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-30 03:40 +0200
        Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Hanjun Guo <hanjun.guo@linaro.org> - 2016-06-30 04:20 +0200
          Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-30 15:30 +0200
            Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Hanjun Guo <hanjun.guo@linaro.org> - 2016-06-30 16:10 +0200
              Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Will Deacon <will.deacon@arm.com> - 2016-07-01 17:30 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-01 23:00 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer "Rafael J. Wysocki" <rafael@kernel.org> - 2016-07-04 15:00 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Graeme Gregory <gg@slimlogic.co.uk> - 2016-07-05 16:20 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer "Rafael J. Wysocki" <rafael@kernel.org> - 2016-07-06 02:10 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Hanjun Guo <hanjun.guo@linaro.org> - 2016-07-07 13:20 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-07 14:00 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-07-07 15:40 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-07 16:00 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Fu Wei <fu.wei@linaro.org> - 2016-07-07 17:30 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-07-08 15:30 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Sudeep Holla <sudeep.holla@arm.com> - 2016-07-08 16:00 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Hanjun Guo <hanjun.guo@linaro.org> - 2016-07-09 05:50 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Hanjun Guo <hanjun.guo@linaro.org> - 2016-07-09 05:10 +0200
            Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-07-01 16:10 +0200
              Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-01 23:00 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-07-04 15:50 +0200
                Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT  support in arm_arch_timer "Rafael J. Wysocki" <rafael@kernel.org> - 2016-07-04 16:20 +0200

csiph-web