Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1433002

Re: [PATCH] w1: Remove unneeded header file

From Julia Lawall <julia.lawall@lip6.fr>
Newsgroups linux.kernel
Subject Re: [PATCH] w1: Remove unneeded header file
Date 2016-06-28 16:00 +0200
Message-ID <rP1It-7PJ-1@gated-at.bofh.it> (permalink)
References <rNsD8-4uY-7@gated-at.bofh.it> <rP0W6-7u6-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, 28 Jun 2016, Evgeniy Polyakov wrote:

> Hi
>
> 24.06.2016, 09:18, "Amitoj Kaur Chawla" <amitoj1606@gmail.com>:
> > Drop redundant include of moduleparam.h
> >
> > The Coccinelle semantic patch used to make this change is as follows:
> > @ includesmodule @
> > @@
> >
> > #include <linux/module.h>
> >
> > @ depends on includesmodule @
> > @@
> >
> > - #include <linux/moduleparam.h>
> >
> > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
>
> Looks good to me, but these @@ are pretty cryptic.

There are two rules.  The first checks for an include of module.h.  The
second depends on the success of the first one.  It removes and include o
moduleparam.h.

julia

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] w1: Remove unneeded header file Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-06-24 08:20 +0200
  Re: [PATCH] w1: Remove unneeded header file Evgeniy Polyakov <zbr@ioremap.net> - 2016-06-28 15:10 +0200
    Re: [PATCH] w1: Remove unneeded header file Julia Lawall <julia.lawall@lip6.fr> - 2016-06-28 16:00 +0200
      Re: [PATCH] w1: Remove unneeded header file Evgeniy Polyakov <zbr@ioremap.net> - 2016-06-28 16:10 +0200

csiph-web