Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1430390 > unrolled thread
| Started by | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| First post | 2016-06-24 08:20 +0200 |
| Last post | 2016-06-28 16:10 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] w1: Remove unneeded header file Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-06-24 08:20 +0200
Re: [PATCH] w1: Remove unneeded header file Evgeniy Polyakov <zbr@ioremap.net> - 2016-06-28 15:10 +0200
Re: [PATCH] w1: Remove unneeded header file Julia Lawall <julia.lawall@lip6.fr> - 2016-06-28 16:00 +0200
Re: [PATCH] w1: Remove unneeded header file Evgeniy Polyakov <zbr@ioremap.net> - 2016-06-28 16:10 +0200
| From | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| Date | 2016-06-24 08:20 +0200 |
| Subject | [PATCH] w1: Remove unneeded header file |
| Message-ID | <rNsD8-4uY-7@gated-at.bofh.it> |
Drop redundant include of moduleparam.h The Coccinelle semantic patch used to make this change is as follows: @ includesmodule @ @@ #include <linux/module.h> @ depends on includesmodule @ @@ - #include <linux/moduleparam.h> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> --- drivers/w1/w1.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 89a7847..a02361d 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -22,7 +22,6 @@ #include <linux/delay.h> #include <linux/kernel.h> #include <linux/module.h> -#include <linux/moduleparam.h> #include <linux/list.h> #include <linux/interrupt.h> #include <linux/spinlock.h> -- 1.9.1
[toc] | [next] | [standalone]
| From | Evgeniy Polyakov <zbr@ioremap.net> |
|---|---|
| Date | 2016-06-28 15:10 +0200 |
| Message-ID | <rP0W6-7u6-29@gated-at.bofh.it> |
| In reply to | #1430390 |
Hi 24.06.2016, 09:18, "Amitoj Kaur Chawla" <amitoj1606@gmail.com>: > Drop redundant include of moduleparam.h > > The Coccinelle semantic patch used to make this change is as follows: > @ includesmodule @ > @@ > > #include <linux/module.h> > > @ depends on includesmodule @ > @@ > > - #include <linux/moduleparam.h> > > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Looks good to me, but these @@ are pretty cryptic.
[toc] | [prev] | [next] | [standalone]
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2016-06-28 16:00 +0200 |
| Message-ID | <rP1It-7PJ-1@gated-at.bofh.it> |
| In reply to | #1432979 |
On Tue, 28 Jun 2016, Evgeniy Polyakov wrote: > Hi > > 24.06.2016, 09:18, "Amitoj Kaur Chawla" <amitoj1606@gmail.com>: > > Drop redundant include of moduleparam.h > > > > The Coccinelle semantic patch used to make this change is as follows: > > @ includesmodule @ > > @@ > > > > #include <linux/module.h> > > > > @ depends on includesmodule @ > > @@ > > > > - #include <linux/moduleparam.h> > > > > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> > > Looks good to me, but these @@ are pretty cryptic. There are two rules. The first checks for an include of module.h. The second depends on the success of the first one. It removes and include o moduleparam.h. julia
[toc] | [prev] | [next] | [standalone]
| From | Evgeniy Polyakov <zbr@ioremap.net> |
|---|---|
| Date | 2016-06-28 16:10 +0200 |
| Message-ID | <rP1S9-88I-19@gated-at.bofh.it> |
| In reply to | #1433002 |
Hi 28.06.2016, 16:50, "Julia Lawall" <julia.lawall@lip6.fr>: >> 24.06.2016, 09:18, "Amitoj Kaur Chawla" <amitoj1606@gmail.com>: >> > The Coccinelle semantic patch used to make this change is as follows: >> > @ includesmodule @ >> > @@ >> > >> > #include <linux/module.h> >> > >> > @ depends on includesmodule @ >> > @@ >> > >> > - #include <linux/moduleparam.h> >> > >> > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> >> >> Looks good to me, but these @@ are pretty cryptic. > > There are two rules. The first checks for an include of module.h. The > second depends on the success of the first one. It removes and include o > moduleparam.h. Ok, I see, it makes much more sense now :) Thank you for clarification
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web