Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1431312

[PATCH 03/19] pinctrl: imx21: make it explicitly non-modular

Show all headers | View raw

The Kconfig currently controlling compilation of this code is:

drivers/pinctrl/freescale/Kconfig:config PINCTRL_IMX21
drivers/pinctrl/freescale/Kconfig:	bool "i.MX21 pinctrl driver"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexander Shiyan <shc_work@mail.ru>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/pinctrl/freescale/pinctrl-imx21.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/pinctrl/freescale/pinctrl-imx21.c b/drivers/pinctrl/freescale/pinctrl-imx21.c
index aa1221f4dbb7..b9f9b3b8eeb1 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx21.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx21.c
@@ -9,7 +9,7 @@
  * (at your option) any later version.
  */
 
-#include <linux/module.h>
+#include <linux/init.h>
 #include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/pinctrl/pinctrl.h>
@@ -333,8 +333,4 @@ static struct platform_driver imx21_pinctrl_driver = {
 		.of_match_table	= imx21_pinctrl_of_match,
 	},
 };
-module_platform_driver_probe(imx21_pinctrl_driver, imx21_pinctrl_probe);
-
-MODULE_AUTHOR("Alexander Shiyan <shc_work@mail.ru>");
-MODULE_DESCRIPTION("Freescale i.MX21 pinctrl driver");
-MODULE_LICENSE("GPL");
+builtin_platform_driver_probe(imx21_pinctrl_driver, imx21_pinctrl_probe);
-- 
2.8.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 00/19] pinctrl/freescale: fix module usage in non-modular code Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 04:50 +0200
  [PATCH 15/19] pinctrl: imx7d: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 04:50 +0200
  [PATCH 11/19] pinctrl: imx6q: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 04:50 +0200
  [PATCH 18/19] pinctrl: imx28: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 14/19] pinctrl: imx6ul: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 04/19] pinctrl: imx25: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 06/19] pinctrl: imx35: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 16/19] pinctrl: vf610: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 07/19] pinctrl: imx50: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 05/19] pinctrl: imx27: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 03/19] pinctrl: imx21: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200

csiph-web