Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1431301

[PATCH 15/19] pinctrl: imx7d: make it explicitly non-modular

Show all headers | View raw

The Kconfig currently controlling compilation of this code is:

drivers/pinctrl/freescale/Kconfig:config PINCTRL_IMX7D
drivers/pinctrl/freescale/Kconfig:	bool "IMX7D pinctrl driver"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

Since module_init was not in use by this driver, the init ordering
remains unchanged with this commit.

We also delete the MODULE_LICENSE tag etc. since all that information
was (or is now) contained at the top of the file in the comments.

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Anson Huang <Anson.Huang@freescale.com>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/pinctrl/freescale/pinctrl-imx7d.c | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/drivers/pinctrl/freescale/pinctrl-imx7d.c b/drivers/pinctrl/freescale/pinctrl-imx7d.c
index d30d91f80dfd..a465a66c3ef4 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx7d.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx7d.c
@@ -1,4 +1,7 @@
 /*
+ * Freescale imx7d pinctrl driver
+ *
+ * Author: Anson Huang <Anson.Huang@freescale.com>
  * Copyright (C) 2014-2015 Freescale Semiconductor, Inc.
  *
  * This program is free software; you can redistribute it and/or modify
@@ -9,7 +12,6 @@
 #include <linux/err.h>
 #include <linux/init.h>
 #include <linux/io.h>
-#include <linux/module.h>
 #include <linux/of.h>
 #include <linux/of_device.h>
 #include <linux/pinctrl/pinctrl.h>
@@ -402,13 +404,3 @@ static int __init imx7d_pinctrl_init(void)
 	return platform_driver_register(&imx7d_pinctrl_driver);
 }
 arch_initcall(imx7d_pinctrl_init);
-
-static void __exit imx7d_pinctrl_exit(void)
-{
-	platform_driver_unregister(&imx7d_pinctrl_driver);
-}
-module_exit(imx7d_pinctrl_exit);
-
-MODULE_AUTHOR("Anson Huang <Anson.Huang@freescale.com>");
-MODULE_DESCRIPTION("Freescale imx7d pinctrl driver");
-MODULE_LICENSE("GPL v2");
-- 
2.8.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/19] pinctrl/freescale: fix module usage in non-modular code Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 04:50 +0200
  [PATCH 15/19] pinctrl: imx7d: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 04:50 +0200
  [PATCH 11/19] pinctrl: imx6q: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 04:50 +0200
  [PATCH 18/19] pinctrl: imx28: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 14/19] pinctrl: imx6ul: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 04/19] pinctrl: imx25: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 06/19] pinctrl: imx35: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 16/19] pinctrl: vf610: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 07/19] pinctrl: imx50: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 05/19] pinctrl: imx27: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 03/19] pinctrl: imx21: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200

csiph-web