Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1431305

[PATCH 18/19] pinctrl: imx28: make it explicitly non-modular

Show all headers | View raw

The Kconfig currently controlling compilation of this code is:

drivers/pinctrl/freescale/Kconfig:config PINCTRL_IMX28
drivers/pinctrl/freescale/Kconfig:	bool

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

We explicitly disallow a driver unbind, since that doesn't have a
sensible use case anyway, and it allows us to drop the ".remove"
code for non-modular drivers.

Since module_init was not in use by this driver, the init ordering
remains unchanged with this commit.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

We also delete the MODULE_LICENSE tag etc. since all that information
was (or is now) contained at the top of the file in the comments.

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/pinctrl/freescale/pinctrl-imx28.c | 17 ++++-------------
 1 file changed, 4 insertions(+), 13 deletions(-)

diff --git a/drivers/pinctrl/freescale/pinctrl-imx28.c b/drivers/pinctrl/freescale/pinctrl-imx28.c
index 5082efec4f72..295236dfb0bc 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx28.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx28.c
@@ -1,4 +1,7 @@
 /*
+ * Freescale i.MX28 pinctrl driver
+ *
+ * Author: Shawn Guo <shawn.guo@linaro.org>
  * Copyright 2012 Freescale Semiconductor, Inc.
  *
  * The code contained herein is licensed under the GNU General Public
@@ -10,7 +13,6 @@
  */
 
 #include <linux/init.h>
-#include <linux/module.h>
 #include <linux/of_device.h>
 #include <linux/pinctrl/pinctrl.h>
 #include "pinctrl-mxs.h"
@@ -392,15 +394,14 @@ static const struct of_device_id imx28_pinctrl_of_match[] = {
 	{ .compatible = "fsl,imx28-pinctrl", },
 	{ /* sentinel */ }
 };
-MODULE_DEVICE_TABLE(of, imx28_pinctrl_of_match);
 
 static struct platform_driver imx28_pinctrl_driver = {
 	.driver = {
 		.name = "imx28-pinctrl",
+		.suppress_bind_attrs = true,
 		.of_match_table = imx28_pinctrl_of_match,
 	},
 	.probe = imx28_pinctrl_probe,
-	.remove = mxs_pinctrl_remove,
 };
 
 static int __init imx28_pinctrl_init(void)
@@ -408,13 +409,3 @@ static int __init imx28_pinctrl_init(void)
 	return platform_driver_register(&imx28_pinctrl_driver);
 }
 postcore_initcall(imx28_pinctrl_init);
-
-static void __exit imx28_pinctrl_exit(void)
-{
-	platform_driver_unregister(&imx28_pinctrl_driver);
-}
-module_exit(imx28_pinctrl_exit);
-
-MODULE_AUTHOR("Shawn Guo <shawn.guo@linaro.org>");
-MODULE_DESCRIPTION("Freescale i.MX28 pinctrl driver");
-MODULE_LICENSE("GPL v2");
-- 
2.8.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/19] pinctrl/freescale: fix module usage in non-modular code Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 04:50 +0200
  [PATCH 15/19] pinctrl: imx7d: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 04:50 +0200
  [PATCH 11/19] pinctrl: imx6q: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 04:50 +0200
  [PATCH 18/19] pinctrl: imx28: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 14/19] pinctrl: imx6ul: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 04/19] pinctrl: imx25: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 06/19] pinctrl: imx35: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 16/19] pinctrl: vf610: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 07/19] pinctrl: imx50: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 05/19] pinctrl: imx27: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200
  [PATCH 03/19] pinctrl: imx21: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-26 05:00 +0200

csiph-web