Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1428567
| From | Neil Armstrong <narmstrong@baylibre.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/5] mfd: qcom-rpm: Add support for pm8018 RPM Regulator |
| Date | 2016-06-22 10:40 +0200 |
| Message-ID | <rMLRw-137-39@gated-at.bofh.it> (permalink) |
| References | <rKZce-5jk-13@gated-at.bofh.it> <rKZcg-5jk-77@gated-at.bofh.it> <rMJmF-7Qy-3@gated-at.bofh.it> |
| Organization | Baylibre |
On 06/22/2016 07:23 AM, Bjorn Andersson wrote:
> On Fri 17 Jun 03:22 PDT 2016, Neil Armstrong wrote:
>
> [..]
>> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> [..]
>> +
>> +static const struct qcom_rpm_data mdm9615_template = {
>> + .version = 3,
>> + .resource_table = mdm9615_rpm_resource_table,
>> + .n_resources = ARRAY_SIZE(mdm9615_rpm_resource_table),
>> +};
>
> Please see:
> https://patchwork.kernel.org/patch/9177159/
>
> You should set the new .sel_size to 4 here, please either rebase ontop
> of Linus patch or send an update after both are merged.
>
>> +
>> static const struct of_device_id qcom_rpm_of_match[] = {
>> { .compatible = "qcom,rpm-apq8064", .data = &apq8064_template },
>> { .compatible = "qcom,rpm-msm8660", .data = &msm8660_template },
>> { .compatible = "qcom,rpm-msm8960", .data = &msm8960_template },
>> { .compatible = "qcom,rpm-ipq8064", .data = &ipq806x_template },
>> + { .compatible = "qcom,rpm-mdm9615", .data = &mdm9615_template },
>> { }
>> };
>> MODULE_DEVICE_TABLE(of, qcom_rpm_of_match);
>> diff --git a/include/dt-bindings/mfd/qcom-rpm.h b/include/dt-bindings/mfd/qcom-rpm.h
>> index 13a9d4b..db85912 100644
>> --- a/include/dt-bindings/mfd/qcom-rpm.h
>> +++ b/include/dt-bindings/mfd/qcom-rpm.h
>> @@ -148,6 +148,29 @@
>> #define QCOM_RPM_SMB208_S2a 138
>> #define QCOM_RPM_SMB208_S2b 139
>>
>> +#define QCOM_RPM_PM8018_SMPS1 200
>
> These numbers are a logical identifier and as such you shouldn't skip
> 140-199.
>
>> +#define QCOM_RPM_PM8018_SMPS2 201
>> +#define QCOM_RPM_PM8018_SMPS3 202
>> +#define QCOM_RPM_PM8018_SMPS4 203
>> +#define QCOM_RPM_PM8018_SMPS5 204
>> +#define QCOM_RPM_PM8018_LDO1 205
>> +#define QCOM_RPM_PM8018_LDO2 206
>> +#define QCOM_RPM_PM8018_LDO3 207
>> +#define QCOM_RPM_PM8018_LDO4 208
>> +#define QCOM_RPM_PM8018_LDO5 209
>> +#define QCOM_RPM_PM8018_LDO6 210
>> +#define QCOM_RPM_PM8018_LDO7 211
>> +#define QCOM_RPM_PM8018_LDO8 212
>> +#define QCOM_RPM_PM8018_LDO9 213
>> +#define QCOM_RPM_PM8018_LDO10 214
>> +#define QCOM_RPM_PM8018_LDO11 215
>> +#define QCOM_RPM_PM8018_LDO12 216
>> +#define QCOM_RPM_PM8018_LDO13 217
>> +#define QCOM_RPM_PM8018_LDO14 218
>> +#define QCOM_RPM_PM8018_LVS1 219
>> +#define QCOM_RPM_NCP 220
>
> We already have PM8921_NCP and PM8058_NCP, so better make this
> QCOM_RPM_PM8018_NCP for consistency.
>
>> +#define QCOM_RPM_VOLTAGE_CORNER 221
>> +
>
> Other then these details
> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> Regards,
> Bjorn
>
Thanks,
I rebased on Linus two patches ("fix offset error for msm8660" and "parametrize also ack selector size")
I suppose I should also drop the QCOM_RPM_VOLTAGE_CORNER rpm entry also ?
Neil
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/5] Add support for the Qualcomm PM8018 PMIC Neil Armstrong <narmstrong@baylibre.com> - 2016-06-17 12:30 +0200
[PATCH 2/5] input: pmic8xxx-pwrkey: Add support for pm8018 pwrkey Neil Armstrong <narmstrong@baylibre.com> - 2016-06-17 12:30 +0200
Re: [PATCH 2/5] input: pmic8xxx-pwrkey: Add support for pm8018 pwrkey Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-06-18 18:30 +0200
Re: [PATCH 2/5] input: pmic8xxx-pwrkey: Add support for pm8018 pwrkey Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-22 07:30 +0200
Re: [PATCH 2/5] input: pmic8xxx-pwrkey: Add support for pm8018 pwrkey Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-06-22 07:50 +0200
[PATCH 5/5] regulator: qcom_rpm-regulator: Add support for pm8018 rpm regulator Neil Armstrong <narmstrong@baylibre.com> - 2016-06-17 12:30 +0200
Re: [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for pm8018 rpm regulator Mark Brown <broonie@kernel.org> - 2016-06-17 14:30 +0200
Re: [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for pm8018 rpm regulator Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-17 19:00 +0200
Re: [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for pm8018 rpm regulator Mark Brown <broonie@kernel.org> - 2016-06-18 12:10 +0200
Re: [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for pm8018 rpm regulator Neil Armstrong <narmstrong@baylibre.com> - 2016-06-20 11:40 +0200
Re: [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for pm8018 rpm regulator Neil Armstrong <narmstrong@baylibre.com> - 2016-06-22 10:50 +0200
[PATCH 4/5] mfd: qcom-rpm: Add support for pm8018 RPM Regulator Neil Armstrong <narmstrong@baylibre.com> - 2016-06-17 12:30 +0200
Re: [PATCH 4/5] mfd: qcom-rpm: Add support for pm8018 RPM Regulator Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-22 08:00 +0200
Re: [PATCH 4/5] mfd: qcom-rpm: Add support for pm8018 RPM Regulator Neil Armstrong <narmstrong@baylibre.com> - 2016-06-22 10:40 +0200
Re: [PATCH 4/5] mfd: qcom-rpm: Add support for pm8018 RPM Regulator Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-22 18:00 +0200
[PATCH 3/5] rtc: rtc-pm8xxx: Add support for pm8018 rtc Neil Armstrong <narmstrong@baylibre.com> - 2016-06-17 12:30 +0200
Re: [PATCH 3/5] rtc: rtc-pm8xxx: Add support for pm8018 rtc Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-21 18:30 +0200
Re: [PATCH 3/5] rtc: rtc-pm8xxx: Add support for pm8018 rtc Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-22 07:20 +0200
csiph-web