Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1425772

Re: [PATCH 2/5] input: pmic8xxx-pwrkey: Add support for pm8018 pwrkey

Show all headers | View raw

Hi Neil,

On Fri, Jun 17, 2016 at 12:22:06PM +0200, Neil Armstrong wrote:
> In order to support pwrkey for Qualcomm MDM9615 SoC, add support
> for the pm8018 pwrkey in pmic8xxx-pwrkey.

Why do we need a new compat string if IP block is compatible with 8921?

> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt | 1 +
>  drivers/input/misc/pmic8xxx-pwrkey.c                           | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt b/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt
> index 588536c..9e530e2 100644
> --- a/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt
> +++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt
> @@ -8,6 +8,7 @@ PROPERTIES
>  	Definition: must be one of:
>  		    "qcom,pm8058-pwrkey"
>  		    "qcom,pm8921-pwrkey"
> +		    "qcom,pm8018-pwrkey"
>  
>  - reg:
>  	Usage: required
> diff --git a/drivers/input/misc/pmic8xxx-pwrkey.c b/drivers/input/misc/pmic8xxx-pwrkey.c
> index 67aab86..f6f9b87 100644
> --- a/drivers/input/misc/pmic8xxx-pwrkey.c
> +++ b/drivers/input/misc/pmic8xxx-pwrkey.c
> @@ -446,6 +446,7 @@ static int pmic8xxx_pwrkey_remove(struct platform_device *pdev)
>  }
>  
>  static const struct of_device_id pm8xxx_pwr_key_id_table[] = {
> +	{ .compatible = "qcom,pm8018-pwrkey", .data = &pm8921_pwrkey_shutdown },
>  	{ .compatible = "qcom,pm8058-pwrkey", .data = &pm8058_pwrkey_shutdown },
>  	{ .compatible = "qcom,pm8921-pwrkey", .data = &pm8921_pwrkey_shutdown },
>  	{ }
> -- 
> 1.9.1
> 

Thanks.

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] Add support for the Qualcomm PM8018 PMIC Neil Armstrong <narmstrong@baylibre.com> - 2016-06-17 12:30 +0200
  [PATCH 2/5] input: pmic8xxx-pwrkey: Add support for pm8018 pwrkey Neil Armstrong <narmstrong@baylibre.com> - 2016-06-17 12:30 +0200
    Re: [PATCH 2/5] input: pmic8xxx-pwrkey: Add support for pm8018 pwrkey Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-06-18 18:30 +0200
    Re: [PATCH 2/5] input: pmic8xxx-pwrkey: Add support for pm8018 pwrkey Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-22 07:30 +0200
      Re: [PATCH 2/5] input: pmic8xxx-pwrkey: Add support for pm8018 pwrkey Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-06-22 07:50 +0200
  [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for pm8018 rpm regulator Neil Armstrong <narmstrong@baylibre.com> - 2016-06-17 12:30 +0200
    Re: [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for  pm8018 rpm regulator Mark Brown <broonie@kernel.org> - 2016-06-17 14:30 +0200
    Re: [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for  pm8018 rpm regulator Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-17 19:00 +0200
      Re: [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for  pm8018 rpm regulator Mark Brown <broonie@kernel.org> - 2016-06-18 12:10 +0200
      Re: [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for pm8018  rpm regulator Neil Armstrong <narmstrong@baylibre.com> - 2016-06-20 11:40 +0200
      Re: [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for pm8018  rpm regulator Neil Armstrong <narmstrong@baylibre.com> - 2016-06-22 10:50 +0200
  [PATCH 4/5] mfd: qcom-rpm: Add support for pm8018 RPM Regulator Neil Armstrong <narmstrong@baylibre.com> - 2016-06-17 12:30 +0200
    Re: [PATCH 4/5] mfd: qcom-rpm: Add support for pm8018 RPM Regulator Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-22 08:00 +0200
      Re: [PATCH 4/5] mfd: qcom-rpm: Add support for pm8018 RPM Regulator Neil Armstrong <narmstrong@baylibre.com> - 2016-06-22 10:40 +0200
        Re: [PATCH 4/5] mfd: qcom-rpm: Add support for pm8018 RPM Regulator Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-22 18:00 +0200
  [PATCH 3/5] rtc: rtc-pm8xxx: Add support for pm8018 rtc Neil Armstrong <narmstrong@baylibre.com> - 2016-06-17 12:30 +0200
    Re: [PATCH 3/5] rtc: rtc-pm8xxx: Add support for pm8018 rtc Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-21 18:30 +0200
    Re: [PATCH 3/5] rtc: rtc-pm8xxx: Add support for pm8018 rtc Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-22 07:20 +0200

csiph-web