Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1425323

Re: [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for pm8018 rpm regulator

Show all headers | View raw

On Fri 17 Jun 03:22 PDT 2016, Neil Armstrong wrote:

> In order to support eh Qualcomm MDM9615 SoC, add support for the
> PM8018 RPM regulator in the qcom_rpm-regulator driver.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
[..]
> diff --git a/drivers/regulator/qcom_rpm-regulator.c b/drivers/regulator/qcom_rpm-regulator.c
[..]
> +/**
> + * enum rpm_vreg_voltage_corner - possible voltage corner values
> + *
> + * These should be used in regulator_set_voltage and rpm_vreg_set_voltage calls
> + * for corner type regulators as if they had units of uV.
> + */
> +enum rpm_vreg_voltage_corner {
> +	RPM_VREG_CORNER_NONE = 1,
> +	RPM_VREG_CORNER_LOW,
> +	RPM_VREG_CORNER_NOMINAL,
> +	RPM_VREG_CORNER_HIGH,
> +};
> +
> +static struct regulator_linear_range corner_ranges[] = {
> +	REGULATOR_LINEAR_RANGE(RPM_VREG_CORNER_NONE, 0,
> +				RPM_VREG_CORNER_HIGH, 1),
> +};
> +
>  static int rpm_reg_write(struct qcom_rpm_reg *vreg,
[..]
> +
> +static const struct qcom_rpm_reg pm8018_corner = {
> +	.desc.linear_ranges = corner_ranges,
> +	.desc.n_linear_ranges = ARRAY_SIZE(corner_ranges),
> +	.desc.n_voltages = 4,
> +	.desc.ops = &uV_ops,
> +	.parts = &rpm8018_corner_parts,
> +};
> +
[..]
> +static const struct rpm_regulator_data rpm_pm8018_regulators[] = {
[..]
> +	{ "dig_corner", QCOM_RPM_VOLTAGE_CORNER, &pm8018_corner,
> +						      "vdd_dig_corner" },
> +
> +	{ }
> +};

We have discussed the corners for a long time and I think we've
concluded that they should be exposed as something like an OPP. What we
have agreed on is that they should not be exposed as a regulator with
voltages 1-4uV.

So please drop the corner for now.

Regards,
Bjorn

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] Add support for the Qualcomm PM8018 PMIC Neil Armstrong <narmstrong@baylibre.com> - 2016-06-17 12:30 +0200
  [PATCH 2/5] input: pmic8xxx-pwrkey: Add support for pm8018 pwrkey Neil Armstrong <narmstrong@baylibre.com> - 2016-06-17 12:30 +0200
    Re: [PATCH 2/5] input: pmic8xxx-pwrkey: Add support for pm8018 pwrkey Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-06-18 18:30 +0200
    Re: [PATCH 2/5] input: pmic8xxx-pwrkey: Add support for pm8018 pwrkey Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-22 07:30 +0200
      Re: [PATCH 2/5] input: pmic8xxx-pwrkey: Add support for pm8018 pwrkey Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-06-22 07:50 +0200
  [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for pm8018 rpm regulator Neil Armstrong <narmstrong@baylibre.com> - 2016-06-17 12:30 +0200
    Re: [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for  pm8018 rpm regulator Mark Brown <broonie@kernel.org> - 2016-06-17 14:30 +0200
    Re: [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for  pm8018 rpm regulator Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-17 19:00 +0200
      Re: [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for  pm8018 rpm regulator Mark Brown <broonie@kernel.org> - 2016-06-18 12:10 +0200
      Re: [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for pm8018  rpm regulator Neil Armstrong <narmstrong@baylibre.com> - 2016-06-20 11:40 +0200
      Re: [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for pm8018  rpm regulator Neil Armstrong <narmstrong@baylibre.com> - 2016-06-22 10:50 +0200
  [PATCH 4/5] mfd: qcom-rpm: Add support for pm8018 RPM Regulator Neil Armstrong <narmstrong@baylibre.com> - 2016-06-17 12:30 +0200
    Re: [PATCH 4/5] mfd: qcom-rpm: Add support for pm8018 RPM Regulator Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-22 08:00 +0200
      Re: [PATCH 4/5] mfd: qcom-rpm: Add support for pm8018 RPM Regulator Neil Armstrong <narmstrong@baylibre.com> - 2016-06-22 10:40 +0200
        Re: [PATCH 4/5] mfd: qcom-rpm: Add support for pm8018 RPM Regulator Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-22 18:00 +0200
  [PATCH 3/5] rtc: rtc-pm8xxx: Add support for pm8018 rtc Neil Armstrong <narmstrong@baylibre.com> - 2016-06-17 12:30 +0200
    Re: [PATCH 3/5] rtc: rtc-pm8xxx: Add support for pm8018 rtc Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-21 18:30 +0200
    Re: [PATCH 3/5] rtc: rtc-pm8xxx: Add support for pm8018 rtc Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-22 07:20 +0200

csiph-web