Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1428512

Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S.

Path csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.unit0.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Andreas Schwab <schwab@suse.de>
Newsgroups linux.kernel
Subject Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S.
Date Wed, 22 Jun 2016 09:50:03 +0200
Message-ID <rML59-wN-41@gated-at.bofh.it> (permalink)
References <rMoBA-2OV-31@gated-at.bofh.it> <rMrJ7-53M-3@gated-at.bofh.it> <rMrJ7-53M-1@gated-at.bofh.it> <rML59-wN-43@gated-at.bofh.it>
X-Yow Well, I'm on the right planet---everyone looks like me!!!
User-Agent Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version 1.0
Content-Type text/plain
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 21
Organization linux.* mail to news gateway
X-Original-Cc Joseph Myers <joseph@codesourcery.com>, <libc-alpha@sourceware.org>, <linux-kernel@vger.kernel.org>, <arnd@arndb.de>, <catalin.marinas@arm.com>, <marcus.shawcroft@arm.com>, <philb@gnu.org>, <davem@davemloft.net>, <szabolcs.nagy@arm.com>, <maxim.kuvyrkov@linaro.org>, <pinskia@gmail.com>, Andrew Pinski <apinski@cavium.com>
X-Original-Date Wed, 22 Jun 2016 09:45:47 +0200
X-Original-Message-ID <mvm60t1psyc.fsf@hawking.suse.de>
X-Original-References <1466485631-3532-1-git-send-email-ynorov@caviumnetworks.com> <1466485631-3532-7-git-send-email-ynorov@caviumnetworks.com> <alpine.DEB.2.20.1606211027120.4526@digraph.polyomino.org.uk> <20160622060227.GA22466@yury-N73SV>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1428512

Show key headers only | View raw


Yury Norov <ynorov@caviumnetworks.com> writes:

> On Tue, Jun 21, 2016 at 10:28:40AM +0000, Joseph Myers wrote:
>> On Tue, 21 Jun 2016, Yury Norov wrote:
>> 
>> > +#ifdef __LP64__
>> > +#define RTLD_START RTLD_START_1("x", "3", "sp")
>> > +#else
>> > +#define RTLD_START RTLD_START_1("w", "2", "wsp")
>> > +#endif
>> 
>> As well as preprocessor indentation, this is missing spaces after '('; 

Before, not after.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S. Joseph Myers <joseph@codesourcery.com> - 2016-06-21 13:10 +0200
  Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S. Andreas Schwab <schwab@suse.de> - 2016-06-22 09:50 +0200
  Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S. Joseph Myers <joseph@codesourcery.com> - 2016-06-22 12:40 +0200

csiph-web