Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1420646

Re: [PATCH 3/3] i.MX: system.c: Replace magic numbers

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [PATCH 3/3] i.MX: system.c: Replace magic numbers
Date 2016-06-13 11:30 +0200
Message-ID <rJwlY-4ho-3@gated-at.bofh.it> (permalink)
References <rJt4J-23X-3@gated-at.bofh.it> <rJt4J-23X-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Sunday, June 12, 2016 10:55:29 PM CEST Andrey Smirnov wrote:
> @@ -61,6 +61,13 @@
>  #define L2X0_LINE_TAG                  0xF30
>  #define L2X0_DEBUG_CTRL                        0xF40
>  #define L310_PREFETCH_CTRL             0xF60
> +#define   L310_DOUBLE_LINEFILL_EN                      BIT(30)
> +#define   L310_INSTRUCTION_PREFETCH_EN                 BIT(29)
> +#define   L310_DATA_PREFETCH_EN                                BIT(28)
> +#define   L310_DOUBLE_LINEFILL_ON_WRAP_READ_DIS                BIT(27)
> +#define   L310_PREFETCH_DROP_EN                                BIT(24)
> +#define   L310_INCR_DOUBLE_LINEFILL_EN                 BIT(23)
> +#define   L310_ESCLUSIVE_SEQUENCE_EN                   BIT(21)
>  #define L310_POWER_CTRL                        0xF80
>  #define   L310_DYNAMIC_CLK_GATING_EN   (1 << 1)
>  #define   L310_STNDBY_MODE_EN          (1 << 0)
> diff --git a/arch/arm/mach-imx/system.c b/arch/arm/mach-imx/system.c
> 


Most of these macros seem to all exist further down in the file already
under slightly differnet names, e.g.

#define L310_PREFETCH_CTRL_DBL_LINEFILL_INCR   BIT(23)

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] i.MX: system.c: Convert goto to if statement Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-13 08:00 +0200
  [PATCH 3/3] i.MX: system.c: Replace magic numbers Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-13 08:00 +0200
    Re: [PATCH 3/3] i.MX: system.c: Replace magic numbers Arnd Bergmann <arnd@arndb.de> - 2016-06-13 11:30 +0200
      Re: [PATCH 3/3] i.MX: system.c: Replace magic numbers Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-06-13 11:50 +0200
    Re: [PATCH 3/3] i.MX: system.c: Replace magic numbers Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-06-13 11:30 +0200
  [RESEND PATCH 2/3] i.MX: system.c: Remove redundant errata 752271 code Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-13 08:00 +0200
  Re: [PATCH 1/3] i.MX: system.c: Convert goto to if statement Arnd Bergmann <arnd@arndb.de> - 2016-06-13 11:30 +0200

csiph-web