Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1420459
| From | Andrey Smirnov <andrew.smirnov@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [RESEND PATCH 2/3] i.MX: system.c: Remove redundant errata 752271 code |
| Date | 2016-06-13 08:00 +0200 |
| Message-ID | <rJt4J-23X-9@gated-at.bofh.it> (permalink) |
| References | <rJt4J-23X-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Applying a fix for ARM errata 752271 would already be taken care by a call to a 'fixup' hook as a part of l2x0_of_init() -> __l2c_init() call chain. Moreso the code in 'fixup' function would do that based on the PL310's revsion information, whereas removed code does so based on SoC version which does not work very well on i.MX6Q+ which identifies itself as i.MX6Q, but is not affected by 752271. Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> --- RESEND, now with Russell King on CC list. arch/arm/mach-imx/system.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/arch/arm/mach-imx/system.c b/arch/arm/mach-imx/system.c index d9f8b0e..b153376 100644 --- a/arch/arm/mach-imx/system.c +++ b/arch/arm/mach-imx/system.c @@ -110,17 +110,6 @@ void __init imx_init_l2cache(void) /* Configure the L2 PREFETCH and POWER registers */ val = readl_relaxed(l2x0_base + L310_PREFETCH_CTRL); val |= 0x70800000; - /* - * The L2 cache controller(PL310) version on the i.MX6D/Q is r3p1-50rel0 - * The L2 cache controller(PL310) version on the i.MX6DL/SOLO/SL is r3p2 - * But according to ARM PL310 errata: 752271 - * ID: 752271: Double linefill feature can cause data corruption - * Fault Status: Present in: r3p0, r3p1, r3p1-50rel0. Fixed in r3p2 - * Workaround: The only workaround to this erratum is to disable the - * double linefill feature. This is the default behavior. - */ - if (cpu_is_imx6q()) - val &= ~(1 << 30 | 1 << 23); writel_relaxed(val, l2x0_base + L310_PREFETCH_CTRL); } -- 2.5.5
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/3] i.MX: system.c: Convert goto to if statement Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-13 08:00 +0200
[PATCH 3/3] i.MX: system.c: Replace magic numbers Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-13 08:00 +0200
Re: [PATCH 3/3] i.MX: system.c: Replace magic numbers Arnd Bergmann <arnd@arndb.de> - 2016-06-13 11:30 +0200
Re: [PATCH 3/3] i.MX: system.c: Replace magic numbers Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-06-13 11:50 +0200
Re: [PATCH 3/3] i.MX: system.c: Replace magic numbers Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-06-13 11:30 +0200
[RESEND PATCH 2/3] i.MX: system.c: Remove redundant errata 752271 code Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-13 08:00 +0200
Re: [PATCH 1/3] i.MX: system.c: Convert goto to if statement Arnd Bergmann <arnd@arndb.de> - 2016-06-13 11:30 +0200
csiph-web