Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1420651

Re: [PATCH 1/3] i.MX: system.c: Convert goto to if statement

Show all headers | View raw

On Sunday, June 12, 2016 10:55:27 PM CEST Andrey Smirnov wrote:
> Using goto here doesn't bring any advantages and only makes the code
> flow less clear. No functional changes.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>

All three patches looks reasonable to me, but now that I looked at
the function, I wonder if we could do another cleanup on top and
not call this function for imx35 at all but instead set the
.l2c_aux_val/.l2c_aux_mask fields in its machine descriptor.

The call to l2x0_of_init(0, ~0) seems to be the only thing we
do on imx35 (where arm,pl310-cache is not present), and the kernel
can do it automatically.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] i.MX: system.c: Convert goto to if statement Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-13 08:00 +0200
  [PATCH 3/3] i.MX: system.c: Replace magic numbers Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-13 08:00 +0200
    Re: [PATCH 3/3] i.MX: system.c: Replace magic numbers Arnd Bergmann <arnd@arndb.de> - 2016-06-13 11:30 +0200
      Re: [PATCH 3/3] i.MX: system.c: Replace magic numbers Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-06-13 11:50 +0200
    Re: [PATCH 3/3] i.MX: system.c: Replace magic numbers Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-06-13 11:30 +0200
  [RESEND PATCH 2/3] i.MX: system.c: Remove redundant errata 752271 code Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-13 08:00 +0200
  Re: [PATCH 1/3] i.MX: system.c: Convert goto to if statement Arnd Bergmann <arnd@arndb.de> - 2016-06-13 11:30 +0200

csiph-web