Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1420327

Re: [PATCH] coccicheck: Allow for overriding spatch flags

Show all headers | View raw

On Sun, 12 Jun 2016, Deepa Dinamani wrote:

> >> >> Documentation/coccinelle.txt suggests using the SPFLAGS
> >> >> make variable to pass additional options to spatch.
> >> >>
> >> >> Reorder the way SPFLAGS is added to FLAGS, to allow
> >> >> for options in the SPFLAGS to override the default
> >> >> --very-quiet option.
> >> >>
> >> >> Similarly, rearrage the FLAGS for org or report mode.
> >> >> This allows for overriding of the default --no-show-diff
> >> >> option through SPFLAGS.
> >> >
> >> > The first looks like a good idea, but do you find a use case for the
> >> > second?  The diff that is shown in org or report mode may be sort of
> >> > random.  It is just an easy hack to reuse the same pattern code for
> >> > context, org, and report modes, but there isn't an intent to see the diff
> >> > produced by context mode in org or report mode.
> >>
> >> I thought this at first, that org report mode wouldn't need it the diff.
> >> But if a user wishes to override the option, then why should we not
> >> accept that the user knows what they are doing?
> >
> > I guess... Another issue is that the org/report mode output comes from
> > python, and the diff output comes from ocaml.  They are not synchronized.
> > Ie, the report won't come out next to the relevant diff.
> 
> Ok. I was just thinking of user as the final authority because I was
> trying to get more
> debug output for my script. And, yes I only wanted to override the --very-quiet.
> I just thought since --no-show-diff was a similar issue, it would be
> good to do the
> same thing here.
> 
> Let me know if you want me to leave out the second rearrange and submit a v2.

I think it doesn't hurt anything, if Nicolas is OK with it.

Thanks for noticing the --very-quiet issue.

julia

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] coccicheck: Allow for overriding spatch flags Deepa Dinamani <deepa.kernel@gmail.com> - 2016-06-12 21:10 +0200
  Re: [PATCH] coccicheck: Allow for overriding spatch flags Julia Lawall <julia.lawall@lip6.fr> - 2016-06-12 21:20 +0200
    Re: [PATCH] coccicheck: Allow for overriding spatch flags Julia Lawall <julia.lawall@lip6.fr> - 2016-06-12 22:40 +0200
      Re: [PATCH] coccicheck: Allow for overriding spatch flags Julia Lawall <julia.lawall@lip6.fr> - 2016-06-12 23:10 +0200
      Re: [PATCH] coccicheck: Allow for overriding spatch flags Deepa Dinamani <deepa.kernel@gmail.com> - 2016-06-12 23:10 +0200
    Re: [PATCH] coccicheck: Allow for overriding spatch flags Deepa Dinamani <deepa.kernel@gmail.com> - 2016-06-12 22:40 +0200
  Re: [PATCH] coccicheck: Allow for overriding spatch flags "Nicolas Palix (LIG)" <Nicolas.Palix@imag.fr> - 2016-06-12 23:40 +0200
    Re: [PATCH] coccicheck: Allow for overriding spatch flags Julia Lawall <julia.lawall@lip6.fr> - 2016-06-12 23:50 +0200
      Re: [PATCH] coccicheck: Allow for overriding spatch flags Michal Marek <mmarek@suse.com> - 2016-06-20 22:40 +0200

csiph-web